-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test jit plugin install with matrix #1164
Merged
Merged
Changes from 53 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
68c47d9
chore: jit-plugin matrix
iowillhoit a28887e
chore: try quotes
iowillhoit e4fd914
chore: trying without fromJson
iowillhoit 1af1e35
chore: try removing newlines
iowillhoit f7ab839
chore: add needs
iowillhoit bc32246
chore: add echo
iowillhoit 5428fec
chore: testing hardcoded values
iowillhoit a7498e4
chore: echo fromJSON output
iowillhoit 755cfee
chore: compact jq
iowillhoit f78d481
chore: tojson
iowillhoit 16f122b
chore: single quotes
iowillhoit 3647c4c
chore: more quotes
iowillhoit 58ac5e0
chore: remove fromjson
iowillhoit d91c012
chore: manual input
iowillhoit a0a4754
chore: double
iowillhoit d859cd6
chore: why
iowillhoit c020bf4
chore: as object
iowillhoit 037a4f0
chore: single quotes
iowillhoit a160443
chore: tojson frist
iowillhoit 45edef6
chore: tojson
iowillhoit b19d9dd
chore: seperate steps
iowillhoit 375795b
chore: more logging
iowillhoit a5dd08a
chore: outputs
iowillhoit b2b1ae3
chore: remove job echo
iowillhoit 2dde5cf
chore: toJson in needs
iowillhoit d59adad
chore: single quotes
iowillhoit 1855fa1
chore: fromjson
iowillhoit 520d586
chore: fromJSON
iowillhoit 6527b1a
chore: to and from json
iowillhoit a645059
chore: no json
iowillhoit 366464d
chore: json job
iowillhoit d271d70
chore: needs not step
iowillhoit ec26bca
chore: swap
iowillhoit 8784fb3
chore: tostring
iowillhoit bbc0398
chore: fromJSON
iowillhoit a1c85ac
chore: tojson in outputs
iowillhoit 7493a8d
chore: forgot needs
iowillhoit 33157d6
chore: order
iowillhoit e52896c
chore: quotes
iowillhoit 67d9d82
chore: singlequotes
iowillhoit a7ec573
chore: wildcard
iowillhoit 7f2295a
chore: oh my it worked, now to tweak it
iowillhoit a585964
chore: non-compact
iowillhoit 603949b
chore: eof
iowillhoit 62e3f9a
chore: hmmm
iowillhoit 137d67d
chore: different format
iowillhoit ba7dfe7
chore: remove tojson
iowillhoit c36a26a
chore: move jit tests to own workflow
iowillhoit ce2da08
Merge branch 'main' into ew/jit-matrix
iowillhoit 93dfb9a
chore: testing removing yarn cache
iowillhoit f14f6cb
Merge branch 'ew/jit-matrix' of github.com:salesforcecli/cli into ew/…
iowillhoit 45d3249
chore: add install retries
iowillhoit f1b2a91
chore: upload/download v3
iowillhoit 52d1d47
chore: bump rel-man
iowillhoit 3929327
Merge branch 'main' into ew/jit-matrix
iowillhoit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
name: jit-install-smoke | ||
|
||
on: | ||
workflow_dispatch: | ||
workflow_call: | ||
|
||
jobs: | ||
manifest: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-node@v3 | ||
with: | ||
cache: yarn | ||
- run: yarn install | ||
- run: yarn build | ||
- run: yarn oclif manifest | ||
- uses: actions/upload-artifact@v3 | ||
with: | ||
name: manifest | ||
path: oclif.manifest.json | ||
|
||
get-jit-plugins: | ||
runs-on: ubuntu-latest | ||
outputs: | ||
jit: ${{ steps.plugins.outputs.jit }} | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Get JIT plugins | ||
id: plugins | ||
# This was a pain to get working, be weary of changing it... | ||
# For the dynamic matrix to work, you have to have a VERY specific format: | ||
# Output must be multiline (no jq -c), quotes matter, cannot use toJSON on output, etc... | ||
# The dynamic matrix needs to use fromJSON when reading the needs output | ||
# Multiline format: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#example-of-a-multiline-string | ||
run: | | ||
{ | ||
echo 'jit<<EOF' | ||
jq '.oclif.jitPlugins | keys' package.json | ||
echo EOF | ||
} >> "$GITHUB_OUTPUT" | ||
|
||
jit-install: | ||
needs: [manifest, get-jit-plugins] | ||
strategy: | ||
matrix: | ||
os: [ubuntu-latest, windows-latest] | ||
jitPlugins: ${{ fromJSON(needs.get-jit-plugins.outputs.jit) }} | ||
runs-on: ${{matrix.os}} | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-node@v3 | ||
with: | ||
node-version: lts/* | ||
- uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main | ||
with: | ||
ignore-scripts: true | ||
- run: yarn build | ||
- uses: actions/download-artifact@v3 | ||
with: | ||
name: manifest | ||
- name: Install JIT plugin | ||
uses: nick-fields/retry@943e742917ac94714d2f408a0e8320f2d1fcafcd | ||
with: | ||
max_attempts: 3 | ||
retry_wait_seconds: 60 | ||
command: yarn sf-release cli:install:jit:test --jit-plugin ${{matrix.jitPlugins}} | ||
timeout_minutes: 60 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once
plugin-release-management
gets released, update here