fix: handle import aliases #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiand391
commented
Jul 23, 2024
| @@ -95,10 +95,12 @@ module.exports = { | |||
| | [no-unnecessary-aliases](docs/rules/no-unnecessary-aliases.md) | Mark when an alias is unnecessary because its only an order permutation, not really a different name | ✈️ ✅ | | | 🔧 | | | |||
| | [no-unnecessary-properties](docs/rules/no-unnecessary-properties.md) | Boolean properties are false by default, so they should not be set to false | | ✈️ ✅ | | 🔧 | | | |||
| | [no-username-properties](docs/rules/no-username-properties.md) | Convert requiresUsername and supportusername to username flags | ✈️ | | | 🔧 | | | |||
| | [only-extend-SfCommand](docs/rules/only-extend-SfCommand.md) | Only allow commands that directly extend SfCommand | | ✈️ ✅ | | | | | |||
There was a problem hiding this comment.
these are from Willie's PR
cristiand391
commented
Jul 23, 2024
| } | ||
| } | ||
|
|
||
| return node.superClass?.type === AST_NODE_TYPES.Identifier && (importedClasses.get(node.superClass.name) == 'SfCommand'); |
There was a problem hiding this comment.
this file contains the most relevant changes, the rest were tests/changes required due to changed funcs signatures.
cristiand391
commented
Jul 23, 2024
| // Handle import aliases | ||
| else if (specifier.type === 'ImportSpecifier' && specifier.local.name !== specifier.imported.name) { | ||
| importedClasses.set(specifier.local.name, specifier.imported.name); | ||
| } |
There was a problem hiding this comment.
mshanemc
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #444
This PR updates the
extendsSfCommandutil to accountSfCommandbeing imported with an alias.Before
commands extending SfCommand directly but using import aliases would get a warn from the new rules:
After:
rules are aware of how
SfCommandis imported.@W-16300123@