External developer friendly changes #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Eric Willhoit. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
iowillhoit
force-pushed
the
ew/external-friendly
branch
from
aebb5a9 to
03bfa8e
Compare
mshanemc
reviewed
Feb 5, 2024
mshanemc
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge yet, additional PRs incoming
TODO: Revert
ew/external-friendlybranch refsWe hard coded our svc-cli-bot username/email in a few spots. Making these workflows not useable to external developers.
This PR looks up the username/password based on the Github Token being used. Additional changes are made to take advantage of this lookup.
Example of a Release working on an external plugin: https://github.com/iowillhoit/plugin-workflow-test/actions/runs/7748104245
Example of this working on an internal plugin (using secrets inherit) https://github.com/salesforcecli/testPackageRelease/actions/runs/7759564485/job/21163873201#step:8:27
@W-14809762@
Other PRs:
oclif/plugin-plugins#784
salesforcecli/plugin-trust#720
salesforcecli/plugin-template-sf-external#110
forcedotcom/source-deploy-retrieve#1226
salesforcecli/cli#1456