Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add output-dir to cache, use it if found W-17919149 #104

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

WillieRuemmele
Copy link
Contributor

What does this PR do?

adds output directory to cache, will read and use it on resume

What issues does this PR fix or reference?

@W-17919149@

@cristiand391
Copy link
Member

QA notes:

🟡 resume respects --output-dir from async run
It does respect it but always writes results in human result (async run requested them in tap format)

➜  plugin-agent git:(wr/cacheOutputDir) sf agent test run --api-name Local_Info_Agent_Test --output-dir res --result-format tap
 ›   Warning: @salesforce/plugin-agent is a linked ESM module and cannot be
 ›   auto-transpiled. Existing compiled source will be used instead.Warning: This command is currently in beta. Any aspect of this command can change without advanced notice. Don't use beta commands in your scripts.

 ───── Agent Test Run: Local_Info_Agent_Test ─────

 ✔ Starting Tests 1.10s
 ◼ Polling for Test Results

 Job ID: 4KBed000000bytFGAQ
 Elapsed Time: 1.13s

Run sf agent test resume --job-id 4KBed000000bytFGAQ to resuming watching this test.
➜  plugin-agent git:(wr/cacheOutputDir) sf agent test resume --job-id 4KBed000000bytFGAQ
 ›   Warning: @salesforce/plugin-agent is a linked ESM module and cannot be
 ›   auto-transpiled. Existing compiled source will be used instead.
Warning: This command is currently in beta. Any aspect of this command can change without advanced notice. Don't use beta commands in your scripts.

 ───── Agent Test Run: Local_Info_Agent_Test ─────

 ✔ Starting Tests 22ms
 ✔ Polling for Test Results 1.58s
   ▸ Status: COMPLETED
   ▸ Completed Test Cases: 2/2
   ▸ Passing Test Cases: 0
   ▸ Failing Test Cases: 2

 Job ID: 4KBed000000bytFGAQ
 Elapsed Time: 1.63s

Created human-readable file at res/test-result-4KBed000000bytFGAQ.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants