Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add test cancel command #5

Merged
merged 6 commits into from
Nov 1, 2024
Merged

fix: add test cancel command #5

merged 6 commits into from
Nov 1, 2024

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Oct 31, 2024

What does this PR do?

Adds a command to cancel an agent test evaluation
Adds a NUT so CI builds will pass.

What issues does this PR fix or reference?

@W-17110700@

@shetzel shetzel requested a review from a team as a code owner November 1, 2024 16:47
@jshackell-sfdc
Copy link
Contributor

@shetzel , I'll wait until the first set of agent commands are further along and sorta working (however we define that in the first phase!) and then do a sweep of the help, okay? I think it's better to do it all at once when we're fairly secure in how they're going to work.

@shetzel
Copy link
Contributor Author

shetzel commented Nov 1, 2024

@shetzel , I'll wait until the first set of agent commands are further along and sorta working (however we define that in the first phase!) and then do a sweep of the help, okay? I think it's better to do it all at once when we're fairly secure in how they're going to work.

Yes I agree. It's too early to have meaningful reviews of these commands, help text, and error messages. Each command will have a separate implementation story where the commands work as intended.

@shetzel shetzel merged commit 15b951f into main Nov 1, 2024
13 checks passed
@shetzel shetzel deleted the sh/add-test-cancel-command branch November 1, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants