Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sh/better auth error #1031

Merged
merged 3 commits into from
May 17, 2024
Merged

Sh/better auth error #1031

merged 3 commits into from
May 17, 2024

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented May 17, 2024

What does this PR do?

Throw the original error to keep all data and error context.
Change the crypto diagnostic test to fail when v2 crypto is not supported.

What issues does this PR fix or reference?

@W-15758926@

Copy link
Contributor

@mshanemc mshanemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, I'll push a commit for the de-dupe thing

yarn.lock Outdated
@@ -1468,6 +1468,29 @@
semver "^7.6.2"
ts-retry-promise "^0.7.1"

"@salesforce/core@^7.3.8":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run npx yarn de-duplicate to only have 1 version of sfdx-core

@mshanemc mshanemc merged commit 6aeaeff into main May 17, 2024
12 checks passed
@mshanemc mshanemc deleted the sh/better-auth-error branch May 17, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants