Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] temp redirect uri #1128

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ EXAMPLES
$ sf org list auth
```

_See code: [src/commands/org/list/auth.ts](https://github.com/salesforcecli/plugin-auth/blob/3.6.48/src/commands/org/list/auth.ts)_
_See code: [src/commands/org/list/auth.ts](https://github.com/salesforcecli/plugin-auth/blob/3.6.49-test.1/src/commands/org/list/auth.ts)_

## `sf org login access-token`

Expand Down Expand Up @@ -162,7 +162,7 @@ FLAG DESCRIPTIONS
To specify a sandbox, set --instance-url to "https://<MyDomainName>--<SandboxName>.sandbox.my.salesforce.com".
```

_See code: [src/commands/org/login/access-token.ts](https://github.com/salesforcecli/plugin-auth/blob/3.6.48/src/commands/org/login/access-token.ts)_
_See code: [src/commands/org/login/access-token.ts](https://github.com/salesforcecli/plugin-auth/blob/3.6.49-test.1/src/commands/org/login/access-token.ts)_

## `sf org login device`

Expand Down Expand Up @@ -222,7 +222,7 @@ FLAG DESCRIPTIONS
To specify a sandbox, set --instance-url to "https://<MyDomainName>--<SandboxName>.sandbox.my.salesforce.com".
```

_See code: [src/commands/org/login/device.ts](https://github.com/salesforcecli/plugin-auth/blob/3.6.48/src/commands/org/login/device.ts)_
_See code: [src/commands/org/login/device.ts](https://github.com/salesforcecli/plugin-auth/blob/3.6.49-test.1/src/commands/org/login/device.ts)_

## `sf org login jwt`

Expand Down Expand Up @@ -313,7 +313,7 @@ FLAG DESCRIPTIONS
To specify a sandbox, set --instance-url to "https://<MyDomainName>--<SandboxName>.sandbox.my.salesforce.com".
```

_See code: [src/commands/org/login/jwt.ts](https://github.com/salesforcecli/plugin-auth/blob/3.6.48/src/commands/org/login/jwt.ts)_
_See code: [src/commands/org/login/jwt.ts](https://github.com/salesforcecli/plugin-auth/blob/3.6.49-test.1/src/commands/org/login/jwt.ts)_

## `sf org login sfdx-url`

Expand Down Expand Up @@ -378,7 +378,7 @@ EXAMPLES
$ echo url | sf org login sfdx-url --sfdx-url-stdin
```

_See code: [src/commands/org/login/sfdx-url.ts](https://github.com/salesforcecli/plugin-auth/blob/3.6.48/src/commands/org/login/sfdx-url.ts)_
_See code: [src/commands/org/login/sfdx-url.ts](https://github.com/salesforcecli/plugin-auth/blob/3.6.49-test.1/src/commands/org/login/sfdx-url.ts)_

## `sf org login web`

Expand Down Expand Up @@ -465,7 +465,7 @@ FLAG DESCRIPTIONS
To specify a sandbox, set --instance-url to "https://<MyDomainName>--<SandboxName>.sandbox.my.salesforce.com".
```

_See code: [src/commands/org/login/web.ts](https://github.com/salesforcecli/plugin-auth/blob/3.6.48/src/commands/org/login/web.ts)_
_See code: [src/commands/org/login/web.ts](https://github.com/salesforcecli/plugin-auth/blob/3.6.49-test.1/src/commands/org/login/web.ts)_

## `sf org logout`

Expand Down Expand Up @@ -526,6 +526,6 @@ FLAG DESCRIPTIONS
All orgs includes Dev Hubs, sandboxes, DE orgs, and expired, deleted, and unknown-status scratch orgs.
```

_See code: [src/commands/org/logout.ts](https://github.com/salesforcecli/plugin-auth/blob/3.6.48/src/commands/org/logout.ts)_
_See code: [src/commands/org/logout.ts](https://github.com/salesforcecli/plugin-auth/blob/3.6.49-test.1/src/commands/org/logout.ts)_

<!-- commandsstop -->
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@salesforce/plugin-auth",
"description": "plugin for sf auth commands",
"version": "3.6.48",
"version": "3.6.49-test.1",
"author": "Salesforce",
"bugs": "https://github.com/forcedotcom/cli/issues",
"dependencies": {
Expand Down
1 change: 1 addition & 0 deletions src/commands/org/login/web.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ export default class LoginWeb extends SfCommand<AuthFields> {
const oauthConfig: OAuth2Config = {
loginUrl: await common.resolveLoginUrl(flags['instance-url']?.href),
clientId: flags['client-id'],
redirectUri: process.env.SF_AUTH_REDIRECT_URL ?? undefined,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genius! Thanks

...(flags['client-id']
? { clientSecret: await this.secretPrompt({ message: commonMessages.getMessage('clientSecretStdin') }) }
: {}),
Expand Down