feat!: migrate to ESM #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: ESM and node 18 minimum
mshanemc
requested changes
Nov 7, 2023
package.json
Outdated
| "open": "^8.2.1", | ||
| "tslib": "^2" | ||
| "chalk": "^5.3.0", | ||
| "inquirer": "^9.2.11", |
There was a problem hiding this comment.
this is using v9 inquirer with the v8 inquirer types. That seems like a bug. Willie had this problem on salesforcecli/plugin-sobject#439 (review)
There was a problem hiding this comment.
The problem is that sf-plugins-core is getting it's type definitions for inquirer from whatever version plugin-auth has. I think sf-plugins-core needs to include inquirer's types as a dependency so that this doesn't happen
mshanemc
approved these changes
Nov 9, 2023
|
[made a few commits for deps and dead code] ✅ auth logout via script
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrate to ESM
Depends on salesforcecli/sf-plugins-core#443
What issues does this PR fix or reference?
@W-14438530@