Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit the messages for "project convert source-behavior" #1018

Merged

Conversation

jshackell-sfdc
Copy link
Contributor

What does this PR do?

Edits the messages for the new "project convert source-behavior" command.

What issues does this PR fix or reference?

@W-15829280@

@jshackell-sfdc jshackell-sfdc requested a review from a team as a code owner May 23, 2024 21:59
@mshanemc mshanemc merged commit cb32aa1 into sm/presets-conversion-command May 24, 2024
35 of 41 checks passed
@mshanemc mshanemc deleted the js/message-convert-source-behavior branch May 24, 2024 12:53
mshanemc added a commit that referenced this pull request May 29, 2024
* feat(wip): decompose command

* feat: convert a project to use a new sourceBehaviorOption

* chore: snapshot/schema

* feat: error for behavior change with no matching types

* refactor: rename the command from design

* chore: ut a function

* test: add a nut, fix bugs that uncovers

* chore: bump sdr for renamed prop

* feat: normalize paths for consistency

* test: more nut for preset conversion

* test: remove redundant nut

* test: win ut only

* refactor: calc preset dir once

* test: windows ut again

* test: restore full test suite

* fix: edit the messages for "project convert source-behavior" (#1018)

* fix: change behavior shortchar

* chore: snapshot/schema

* Update messages/convert.source-behavior.md

Co-authored-by: Willhoit <[email protected]>

* chore: pr suggestions

Co-authored-by: Willhoit <[email protected]>

---------

Co-authored-by: Juliet Shackell <[email protected]>
Co-authored-by: Eric Willhoit <[email protected]>
Co-authored-by: Willhoit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants