Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: restore some config.bin for --help stuff #1029

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

we agreed that config.bin in help was maybe useful

What issues does this PR fix or reference?

followup to @W-15867611@

@mshanemc mshanemc requested a review from a team as a code owner May 30, 2024 19:02
@mshanemc mshanemc requested a review from mdonnalley May 30, 2024 19:58
@@ -20,41 +20,41 @@ To deploy multiple metadata components, either set multiple --metadata <name> fl

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshanemc , you missed one, see previous line (for some reason I can't actually click in there in the GH UI, so this comment will have to do)

Copy link
Contributor

@jshackell-sfdc jshackell-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --help looks good, and I regen'd the CLI Ref and all is good. See my comment for one example you missed.

@mshanemc mshanemc merged commit 816d9d9 into main Jun 3, 2024
6 checks passed
@mshanemc mshanemc deleted the sm/removes-dynamic-bin-from-messages branch June 3, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants