Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support resuming completed deployments #762

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Sep 25, 2023

What does this PR do?

A completed deployment can now be resumed. Also removes the poll function since SDR's pollStatus should be used instead.

What issues does this PR fix or reference?

@W-14149965@

QA:
sf project deploy resume should display the deploy results from already completed deployments rather than throwing an error.

Copy link
Contributor

@jshackell-sfdc jshackell-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the info about --wait, because I think it's important.

messages/deploy.metadata.report.md Outdated Show resolved Hide resolved
messages/deploy.metadata.resume.md Outdated Show resolved Hide resolved
messages/deploy.metadata.resume.md Outdated Show resolved Hide resolved
messages/deploy.metadata.resume.md Outdated Show resolved Hide resolved
messages/deploy.metadata.report.md Outdated Show resolved Hide resolved
@mshanemc
Copy link
Contributor

mshanemc commented Sep 26, 2023

QA notes: using dreamhouse-lwc

  1. ../plugin-deploy-retrieve/bin/dev project:deploy:start --async
  2. ../plugin-deploy-retrieve/bin/dev project:deploy:resume --job-id 0Af8F00000sSgGXSA0
    [confirm job is in cache as completed]
"0Af8F00000sSgGXSA0": {
    "async": true,
    "dry-run": false,
    "ignore-conflicts": false,
    "ignore-errors": false,
    "ignore-warnings": false,
    "target-org": "[email protected]",
    "api": "SOAP",
    "manifest": "/Users/shane.mclaughlin/.sf/manifestCache/0Af8F00000sSgGXSA0.xml",
    "wait": 33,
    "isMdapi": false,
    "timestamp": "2023-09-26T14:02:45.934Z",
    "status": "Succeeded"
  }

✅ see warning Warning: Job ID 0Af8F00000sSgGXSA0 is not resumable since it already completed with status: Succeeded. Displaying results...
✅ see output
sf project deploy preview shows nothing to deploy since we resumed it already

✅ did another deploy with --source-dir force-app to resume while still in progress to check polling


validate/quick

../plugin-deploy-retrieve/bin/dev project:deploy:validate --test-level RunAllTestsInOrg --source-dir force-app
✅ ../plugin-deploy-retrieve/bin/dev project:deploy:quick --job-id 0Af8F00000sSiFqSAK

shetzel and others added 2 commits September 26, 2023 09:06
Copy link
Contributor

@jshackell-sfdc jshackell-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a new paragraph about --target-org in the report command, because I thought it was useful information. I think I got it right, but please correct if not!

@shetzel shetzel merged commit cdfb838 into main Sep 26, 2023
0 of 4 checks passed
@shetzel shetzel deleted the sh/resume-successful branch September 26, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants