fix: quick deploy polling uses the new deploy ID #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shetzel
commented
Nov 16, 2023
| exitCode: 0, | ||
| }); | ||
| assert(deploy); | ||
| assert(deploy.result.id !== validation.result.id, 'deploy result ID should not be the validation ID'); |
There was a problem hiding this comment.
This assertion verifies the correct behavior. If you remove the fix from quick.ts these tests will fail.
shetzel
commented
Nov 16, 2023
| apiOptions: { | ||
| rest: api === API['REST'], | ||
| }, | ||
| }); | ||
| const result = await mdapiDeploy.pollStatus({ |
There was a problem hiding this comment.
The polling was reusing the MetadataApiDeploy instance created from the validation ID (aka jobId) so it was polling for the validation deploy status, not the deployRecentValidation status.
mshanemc
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes quick deploy to use the new deploy ID and not the validation ID. Augments NUTs to ensure this behavior.
What issues does this PR fix or reference?
@W-14481091@
forcedotcom/cli#2537