Wr/add missing local components #959
Conversation
| @@ -25,6 +25,7 @@ import { | |||
| JUnitReporter, | |||
| TestResult, | |||
| } from '@salesforce/apex-node'; | |||
| import { getState } from '@salesforce/source-deploy-retrieve/lib/src/client/deployMessages.js'; | |||
There was a problem hiding this comment.
We shouldn't do this kind of import. If we need this method it should be made public in SDR and exported.
| filePath: 'Not found in project', | ||
| }) | ||
| ); | ||
|
|
There was a problem hiding this comment.
IMO, SDR should do this. Other clients may have the same problem and need this code. I think SDR should report everything that happened, using the ComponentSet when possible to provide accurate file paths, but if not then use the file path from the response. That means updating MetadataApiDeploy.buildFileResponsesFromComponentSet(). @mshanemc - what are your thoughts?
There was a problem hiding this comment.
I tried that, but NUTs had errors, maybe there's a different method, or a new one, but I don't think getFileResponses is it
There was a problem hiding this comment.
I like your SDR solution better (made 1 comment there).
I think the NUT failures look to all be source-testkit related, here:
https://github.com/salesforcecli/source-testkit/blob/b5801a5ab89c044e94fd1ce14547ffe3dba9bf9f/src/assertions.ts#L120-L121
So maybe explore why that's hitting missing files?
What does this PR do?
adds new remote component to
deploy reportoutputWhat issues does this PR fix or reference?
#forcedotcom/cli#2603, @W-14675377@