Skip to content

Commit

Permalink
Quick deployments from bundling stage (#292)
Browse files Browse the repository at this point in the history
* chore(dev-deps): bump salesforce/dev-scripts from 5.12.3 to 6.0.4

* feat: add support for validate-only and quick deployments from the bundling stage
  • Loading branch information
EstebanRomero84 authored Nov 28, 2023
1 parent 8a6665a commit 8259e36
Show file tree
Hide file tree
Showing 6 changed files with 890 additions and 1,051 deletions.
24 changes: 2 additions & 22 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,36 +15,16 @@
"@oclif/plugin-command-snapshot": "^4.0.14",
"@oclif/test": "^2.4.2",
"@salesforce/cli-plugins-testkit": "^4.4.12",
"@salesforce/dev-config": "^4.1.0",
"@salesforce/dev-scripts": "^5.12.3",
"@salesforce/dev-scripts": "^6.0.4",
"@salesforce/plugin-command-reference": "^3.0.42",
"@salesforce/prettier-config": "^0.0.3",
"@salesforce/ts-sinon": "^1.4.19",
"@swc/cli": "^0.1.62",
"@swc/core": "1.3.39",
"@typescript-eslint/eslint-plugin": "^6.10.0",
"@typescript-eslint/parser": "^6.12.0",
"chai": "^4.3.10",
"eslint": "^8.51.0",
"eslint-config-prettier": "^8.10.0",
"eslint-config-salesforce": "^2.0.1",
"eslint-config-salesforce-license": "^0.2.0",
"eslint-config-salesforce-typescript": "^1.1.2",
"eslint-plugin-header": "^3.1.1",
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-jsdoc": "^46.9.0",
"eslint-plugin-sf-plugin": "^1.16.3",
"husky": "^7.0.4",
"mocha": "^9.2.2",
"nyc": "^15.1.0",
"oclif": "^3.17.2",
"prettier": "^2.8.7",
"pretty-quick": "^3.1.3",
"shx": "0.3.4",
"sinon": "10.0.0",
"ts-node": "^10.9.1",
"typescript": "^4.9.5",
"wireit": "^0.14.1"
"typescript": "^4.9.5"
},
"engines": {
"node": ">=16.0.0"
Expand Down
1 change: 0 additions & 1 deletion src/common/base/abstractQuick.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ export default abstract class QuickPromotionCommand<T extends typeof SfCommand>
*/
private buildPromoteOptions(deployId: string): void {
this.deployOptions = {
testLevel: 'Default',
deploymentId: deployId,
// get more promote options from the concrete implementation if needed
...this.getPromoteOptions(),
Expand Down
2 changes: 1 addition & 1 deletion src/configMeta.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
*/

import { spawnSync } from 'child_process';
import { spawnSync } from 'node:child_process';
import { ConfigValue, Messages } from '@salesforce/core';

Messages.importMessagesDirectory(__dirname);
Expand Down
1 change: 0 additions & 1 deletion test/commands/project/deploy/pipeline/quick.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,6 @@ describe('project deploy pipeline quick', () => {
// we can get the call argument
// and validate its values
const requestArgument = requestMock.getCall(0).args[0] as HttpRequest;
expect(requestArgument.body).to.contain('"testLevel":"Default"');
expect(requestArgument.body).to.contain(`"deploymentId":"${mockDeploymentId}"`);
expect(requestArgument.body).to.contain('"undeployedOnly":true');
});
Expand Down
2 changes: 1 addition & 1 deletion test/configMeta.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
*/

import * as spawnSync from 'child_process';
import * as spawnSync from 'node:child_process';
import { expect } from '@oclif/test';
import * as sinon from 'sinon';
import configMeta from '../src/configMeta';
Expand Down
Loading

0 comments on commit 8259e36

Please sign in to comment.