Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default from wait flag #330

Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix: remove default from wait flag #330

merged 2 commits into from
Mar 14, 2024

Conversation

mdonnalley
Copy link
Contributor

What does this PR do?

Setting default to a complex value like Duration causes help to show --wait=<value> [default: [object Object]]. The duration flag from sf-plugins-core will set a defaultHelp that will render the Duration class to a readable string (PR)

What issues does this PR fix or reference?

@W-14625639@

@mdonnalley mdonnalley requested a review from a team as a code owner March 13, 2024 20:45
@mdonnalley mdonnalley changed the title fix: use unit on wait flag fix: remove default from wait flag Mar 13, 2024
@EstebanRomero84 EstebanRomero84 merged commit cfcba21 into main Mar 14, 2024
11 checks passed
@mdonnalley mdonnalley deleted the mdonnalley/wait branch May 9, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants