feat: add --json to compute add collaborator #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Git2Gus App is installed but the |
jheikes515
commented
Jul 28, 2022
saracope
requested changes
Jul 29, 2022
| @@ -74,5 +72,8 @@ export default class ComputeCollaboratorAdd extends Command { | |||
| this.log( | |||
| 'For more information about attaching Heroku add-ons to your compute environments, run $ heroku addons:attach --help.' | |||
| ); | |||
| return { | |||
There was a problem hiding this comment.
If the user includes the --json flag, the error output should be in json also.
Try adding in:
if (shouldExitNonZero) {
this.exit(1);
}
There was a problem hiding this comment.
Example here
| @@ -33,13 +41,25 @@ describe('sf env compute collaborator add', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| test | |||
There was a problem hiding this comment.
Also add in a failing testing for the --json flag
| test | ||
| .stdout() | ||
| .stderr() | ||
| .nock('https://api.heroku.com', (api) => api.post('/salesforce-orgs/collaborators').reply(404, {})) | ||
| .command(['env:compute:collaborator:add', '-h', HEROKU_USER]) | ||
| .catch((error) => { | ||
| expect(error.message).contains(`${herokuColor.heroku(HEROKU_USER)} does not exist.`); | ||
| expect(error.message).contains(`Couldn't find Heroku user ${herokuColor.heroku(HEROKU_USER)}.`); |
There was a problem hiding this comment.
See previous comment about this change. I'm not sure it's needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds JSON support to sf env compute collaborator add, referenced in Elastic Services DX CLI Improvements for 240
What issues does this PR fix or reference?
See above.