-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: migrate to ESM #550
Conversation
BREAKING CHANGES: ESM and node 18 minimum
"init": [ | ||
"./lib/hooks/init/init_doctor.js" | ||
] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this hook removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not needed because we can initialize the Doctor
class at the beginning of the doctor
command execution. Also hooks are fairly expensive in terms of performance, especially the init
hooks since they'll run on every single command execution, even --help
and --version
BREAKING CHANGES: ESM and node 18 minimum
What does this PR do?
__dirname
andrequire()
oclif.lock
What issues does this PR fix or reference?
[skip-validate-pr]