Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backport): support node 22+ #292

Merged
merged 5 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# CI Info

[Github Workflows Readme](https://github.com/salesforcecli/github-workflows)

## Releasing a new version

[Release Workflow](https://github.com/salesforcecli/plugin-lightning-dev/actions/workflows/create-github-release.yml)

## Node Version Configuration

This repository provides flexibility to manage Node.js versions in CI workflows using repository variables.
These variables can be configured at the repository level via the [Actions settings page](https://github.com/salesforcecli/plugin-lightning-dev/settings/variables/actions).
These can also be supplied as arguments to individual workflows directly.

### `UT_DISABLE_NODE_CURRENT`

- Disables the latest Node.js version in GitHub Actions workflows.

### `UT_DISABLE_NODE_PREVIOUS`

- Disables the previous Node.js version in GitHub Actions workflows.

### `NODE_VERSION_OVERRIDE`

- Overrides the full set of Node.js versions used for testing and publishing.
- **Default:** `'lts/*'` and `'lts/-1'`.
1 change: 0 additions & 1 deletion .github/workflows/onRelease.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,5 @@ jobs:
sign: true
tag: ${{ needs.getDistTag.outputs.tag || (needs.getMajorVersion.outputs.major == '1') && 'latest' || 'next' }}
githubTag: ${{ github.event.release.tag_name || inputs.tag }}
nodeVersion: 20.18.0

secrets: inherit
1 change: 0 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,3 @@ jobs:
fail-fast: false
with:
os: ${{ matrix.os }}
nodeVersion: 20.18.0
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ To build the plugin locally, make sure to have yarn installed and run the follow
# Clone the repository
git clone [email protected]:salesforcecli/plugin-lightning-dev

# Install the dependencies and compile
# Install the dependencies and compile the plugin
yarn && yarn build
```

Expand Down Expand Up @@ -200,7 +200,7 @@ EXAMPLES
$ sf lightning dev app --target-org myOrg --device-type ios --device-id "iPhone 15 Pro Max"
```

_See code: [src/commands/lightning/dev/app.ts](https://github.com/salesforcecli/plugin-lightning-dev/blob/1.9.4/src/commands/lightning/dev/app.ts)_
_See code: [src/commands/lightning/dev/app.ts](https://github.com/salesforcecli/plugin-lightning-dev/blob/1.9.5-alpha.0/src/commands/lightning/dev/app.ts)_

## `sf lightning dev site`

Expand Down Expand Up @@ -244,6 +244,6 @@ EXAMPLES
$ sf lightning dev site --name "Partner Central" --target-org myOrg
```

_See code: [src/commands/lightning/dev/site.ts](https://github.com/salesforcecli/plugin-lightning-dev/blob/1.9.4/src/commands/lightning/dev/site.ts)_
_See code: [src/commands/lightning/dev/site.ts](https://github.com/salesforcecli/plugin-lightning-dev/blob/1.9.5-alpha.0/src/commands/lightning/dev/site.ts)_

<!-- commandsstop -->
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
{
"name": "@salesforce/plugin-lightning-dev",
"description": "Lightning development tools for LEX, Mobile, and Experience Sites",
"version": "1.9.4",
"version": "1.9.5-alpha.0",
"author": "Salesforce",
"bugs": "https://github.com/forcedotcom/cli/issues",
"dependencies": {
"@inquirer/prompts": "^5.3.8",
"@inquirer/select": "^2.4.7",
"@lwc/lwc-dev-server": "^9.5.3",
"@lwc/sfdc-lwc-compiler": "^9.5.3",
"@lwrjs/api": "0.14.3",
"@lwrjs/api": "0.14.5",
"@oclif/core": "^4.0.17",
"@salesforce/core": "^8.2.7",
"@salesforce/kit": "^3.1.6",
Expand All @@ -18,7 +18,6 @@
"axios": "^1.7.7",
"glob": "10.4.5",
"lwc": "7.1.3",
"lwr": "0.14.3",
"node-fetch": "^3.3.2"
},
"devDependencies": {
Expand All @@ -34,7 +33,7 @@
"typescript": "^5.5.4"
},
"engines": {
"node": ">=18.0.0 <22"
"node": ">=18.0.0"
},
"files": [
"/lib",
Expand Down Expand Up @@ -219,6 +218,7 @@
"exports": "./lib/index.js",
"type": "module",
"volta": {
"node": "20.11.0"
"node": "20.11.0",
"yarn": "1.22.22"
}
}
Loading
Loading