Ensure sfdx dir exists #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
requested changes
Jun 16, 2023
| @@ -129,6 +129,10 @@ export class OrgListUtil { | |||
| * @param fileNames All the filenames in the global hidden folder | |||
| */ | |||
| public static async readAuthFiles(fileNames: string[]): Promise<AuthInfo[]> { | |||
| // Ensure that the Global.SFDX_DIR exists | |||
| // https://github.com/forcedotcom/cli/issues/2222 | |||
| await fs.mkdir(Global.SFDX_DIR, { recursive: true }); | |||
There was a problem hiding this comment.
this'll throw if the directory already exists though, do we need to wrap this in try/catch?
just testing this in dreamhouse
➜ ls
1686770905635-command-debug.log CODE_OF_CONDUCT.md SECURITY.md data jest.config.js tests
1686770905635-command-stdout.log CONTRIBUTION.md bin dreamhouse-logo.png package-lock.json
1686770924292-command-debug.log LICENSE codecov.yml force-app package.json
1686770924292-command-stdout.log README.md config jest-sa11y-setup.js sfdx-project.json
➜ dreamhouse-lwc git:(main) ✗ hub:(DevHub) scratch:([email protected])
➜ node
Welcome to Node.js v18.16.0.
Type ".help" for more information.
> fs.mkdirSync('config')
Uncaught Error: EEXIST: file already exists, mkdir 'config'
at Object.mkdirSync (node:fs:1396:3) {
errno: -17,
syscall: 'mkdir',
code: 'EEXIST',
path: 'config'
}
There was a problem hiding this comment.
Oh! I didn't look closely at what you were testing. The mkdir function will throw if you are not passing { recursive: true } (docs). I just tested this code several more times and it is working as expected.
WillieRuemmele
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents forcedotcom/cli#2222 from happening again.
This was unintentionally fixed in forcedotcom/sfdx-core#842
What issues does this PR fix or reference?
@W-13602928@
QA
I reverted back to an older version of the CLI (1.194.1) and then I modified
plugin-orgdirectly with the samemkdircodeConfirm existing directory does not cause issues
