chore: move styled headers into table title

salesforcecli · Oct 30, 2024 · 15927e7 · 15927e7
1 parent 197bc69
commit 15927e7
Show file tree

Hide file tree

Showing 8 changed files with 6 additions and 19 deletions.
diff --git a/src/commands/package/create.ts b/src/commands/package/create.ts
@@ -93,7 +93,6 @@ export class PackageCreateCommand extends SfCommand<PackageCreate> {
   }
 
   private display(result: PackageCreate): void {
-    this.styledHeader('Ids');
-    this.table({ data: [{ name: 'Package Id', value: result.Id }] });
+    this.table({ data: [{ name: 'Package Id', value: result.Id }], title: 'Ids' });
   }
 }
diff --git a/src/commands/package/list.ts b/src/commands/package/list.ts
@@ -60,8 +60,6 @@ export class PackageListCommand extends SfCommand<PackageListCommandResult> {
   }
 
   private displayResults(results: Package2Result[], verbose = false, apiVersion: string): void {
-    this.styledHeader(chalk.blue(`Packages [${results.length}]`));
-
     const data = results.map((r) => ({
       'Namespace Prefix': r.NamespacePrefix,
       Name: r.Name,
@@ -80,7 +78,7 @@ export class PackageListCommand extends SfCommand<PackageListCommandResult> {
           }
         : {}),
     }));
-    this.table({ data });
+    this.table({ data, title: chalk.blue(`Packages [${results.length}]`) });
   }
 }
 

diff --git a/src/commands/package/version/create/list.ts b/src/commands/package/version/create/list.ts
@@ -68,8 +68,6 @@ export class PackageVersionCreateListCommand extends SfCommand<CreateListCommand
     if (results.length === 0) {
       this.warn('No results found');
     } else {
-      this.styledHeader(chalk.blue(`Package Version Create Requests  [${results.length}]`));
-
       if (flags.verbose) {
         try {
           results = await this.fetchVerboseData(results);
@@ -93,7 +91,7 @@ export class PackageVersionCreateListCommand extends SfCommand<CreateListCommand
         ...(flags.verbose ? { 'Version Name': r.VersionName, 'Version Number': r.VersionNumber } : {}),
       }));
 
-      this.table({ data, overflow: 'wrap' });
+      this.table({ data, overflow: 'wrap', title: chalk.blue(`Package Version Create Requests  [${results.length}]`) });
     }
 
     return results;

diff --git a/src/commands/package/version/create/report.ts b/src/commands/package/version/create/report.ts
@@ -106,8 +106,7 @@ export class PackageVersionCreateReportCommand extends SfCommand<ReportCommandRe
       });
     }
 
-    this.styledHeader(chalk.blue('Package Version Create Request'));
-    this.table({ data });
+    this.table({ data, title: chalk.blue('Package Version Create Request') });
 
     if (record.Error?.length > 0) {
       this.log('');

diff --git a/src/commands/package/version/list.ts b/src/commands/package/version/list.ts
@@ -214,8 +214,8 @@ export class PackageVersionListCommand extends SfCommand<PackageVersionListComma
           Language: record.Language,
         });
       });
-      this.styledHeader(`Package Versions [${results.length}]`);
       this.table({
+        title: `Package Versions [${results.length}]`,
         data: results,
         overflow: 'wrap',
         columns: getColumnData(flags.concise, flags.verbose, flags['show-conversions-only']),

diff --git a/src/commands/package/version/report.ts b/src/commands/package/version/report.ts
@@ -212,8 +212,7 @@ export class PackageVersionReportCommand extends SfCommand<PackageVersionReportR
       );
       displayCoverageRecords.splice(0, displayCoverageRecords.length);
     }
-    this.styledHeader(chalk.blue('Package Version'));
-    this.table({ data: displayRecords });
+    this.table({ data: displayRecords, title: chalk.blue('Package Version') });
     if (displayCoverageRecords.length > 0) {
       this.table({ data: displayCoverageRecords });
     }

diff --git a/test/commands/package/packageVersionCreateReport.test.ts b/test/commands/package/packageVersionCreateReport.test.ts
@@ -85,13 +85,11 @@ describe('package:version:create:report - tests', () => {
   const testOrg = new MockTestOrgData();
   let createStatusStub = $$.SANDBOX.stub(PackageVersion, 'getCreateStatus');
   let tableStub: sinon.SinonStub;
-  let styledHeaderStub: sinon.SinonStub;
   let warnStub: sinon.SinonStub;
   const config = new Config({ root: import.meta.url });
 
   beforeEach(async () => {
     warnStub = $$.SANDBOX.stub(SfCommand.prototype, 'warn');
-    styledHeaderStub = $$.SANDBOX.stub(SfCommand.prototype, 'styledHeader');
     tableStub = $$.SANDBOX.stub(SfCommand.prototype, 'table');
   });
 
@@ -129,7 +127,6 @@ describe('package:version:create:report - tests', () => {
         },
       ]);
       expect(tableStub.callCount).to.equal(1);
-      expect(styledHeaderStub.callCount).to.equal(1);
     });
 
     it('should report on a new package version with async validation', async () => {
@@ -157,7 +154,6 @@ describe('package:version:create:report - tests', () => {
         },
       ]);
       expect(tableStub.callCount).to.equal(1);
-      expect(styledHeaderStub.callCount).to.equal(1);
     });
 
     it('should report multiple errors', async () => {

diff --git a/test/commands/package/versionReport.test.ts b/test/commands/package/versionReport.test.ts
@@ -148,8 +148,6 @@ describe('package:version:report - tests', () => {
       expect(result).to.deep.equal(pkgVersionReportResultModified);
       expect(uxLogStub.calledOnce).to.be.false;
       expect(uxTableStub.calledOnce).to.be.true;
-      expect(uxStyledHeaderStub.calledOnce).to.be.true;
-      expect(uxStyledHeaderStub.args[0][0]).to.include('Package Version');
     });
     it('should produce package version report - json result', async () => {
       const reportResult = Object.assign({}, pkgVersionReportResult);