Merge pull request #483 from salesforcecli/devScripts2023-11-05

refactor: devScripts update

package.json

@@ -17,37 +17,17 @@
   "devDependencies": {
     "@oclif/plugin-command-snapshot": "^4.0.14",
     "@salesforce/cli-plugins-testkit": "^4.4.2",
-    "@salesforce/dev-config": "^4.1.0",
-    "@salesforce/dev-scripts": "^5.12.2",
+    "@salesforce/dev-scripts": "^6.0.3",
     "@salesforce/plugin-auth": "^2.8.25",
     "@salesforce/plugin-command-reference": "^3.0.39",
-    "@salesforce/prettier-config": "^0.0.3",
     "@salesforce/ts-sinon": "^1.4.14",
     "@salesforce/ts-types": "^2.0.6",
     "@swc/core": "1.3.39",
-    "@typescript-eslint/eslint-plugin": "^5.61.0",
-    "@typescript-eslint/parser": "^5.61.0",
-    "chai": "^4.3.10",
-    "eslint": "^8.52.0",
-    "eslint-config-prettier": "^8.8.0",
-    "eslint-config-salesforce": "^2.0.1",
-    "eslint-config-salesforce-license": "^0.2.0",
-    "eslint-config-salesforce-typescript": "^2.0.0",
-    "eslint-plugin-header": "^3.1.1",
-    "eslint-plugin-import": "^2.27.5",
-    "eslint-plugin-jsdoc": "^46.8.2",
     "eslint-plugin-sf-plugin": "^1.16.10",
-    "husky": "^7.0.4",
-    "mocha": "^9.1.3",
-    "nyc": "^15.1.0",
     "oclif": "^3.16.0",
-    "prettier": "^2.8.8",
-    "pretty-quick": "^3.1.3",
     "shx": "0.3.4",
-    "sinon": "^11.1.2",
-    "ts-node": "^10.8.1",
-    "typescript": "^5.2.2",
-    "wireit": "^0.14.1"
+    "ts-node": "^10.9.1",
+    "typescript": "^5.2.2"
   },
   "config": {},
   "engines": {

src/commands/package/version/create/report.ts

@@ -55,7 +55,9 @@ export class PackageVersionCreateReportCommand extends SfCommand<ReportCommandRe
 
   private display(record: PackageVersionCreateRequestResult, requestId: string, devOrg: Org): void {
     const installUrlValue =
-      record.Status === 'Success' ? `${pkgUtils.INSTALL_URL_BASE.toString()}${record.SubscriberPackageVersionId}` : '';
+      record.Status.toString() === 'Success'
+        ? `${pkgUtils.INSTALL_URL_BASE.toString()}${record.SubscriberPackageVersionId}`
+        : '';
 
     const data = [
       {

src/commands/package/version/list.ts

@@ -147,7 +147,7 @@ export class PackageVersionListCommand extends SfCommand<PackageVersionListComma
         const codeCoverage =
           record.CodeCoverage?.apexCodeCoveragePercentage != null
             ? `${record.CodeCoverage.apexCodeCoveragePercentage.toString()}%`
-            : record.Package2.IsOrgDependent || record.ValidationSkipped
+            : Boolean(record.Package2.IsOrgDependent) || record.ValidationSkipped
             ? 'N/A'
             : '';
 
@@ -196,7 +196,7 @@ export class PackageVersionListCommand extends SfCommand<PackageVersionListComma
           Alias: AliasStr,
           IsOrgDependent: isOrgDependent,
           ReleaseVersion: record.ReleaseVersion == null ? '' : Number.parseFloat(record.ReleaseVersion).toFixed(1),
-          BuildDurationInSeconds: record.BuildDurationInSeconds == null ? '' : record.BuildDurationInSeconds,
+          BuildDurationInSeconds: record.BuildDurationInSeconds ?? '',
           HasMetadataRemoved: hasMetadataRemoved,
           CreatedBy: record.CreatedById,
           Language: record.Language,

src/commands/package/version/report.ts

@@ -236,7 +236,7 @@ export class PackageVersionReportCommand extends SfCommand<PackageVersionReportR
     }
 
     record.HasPassedCodeCoverageCheck =
-      results.Package2.IsOrgDependent || results.ValidationSkipped
+      Boolean(results.Package2.IsOrgDependent) || results.ValidationSkipped
         ? 'N/A'
         : results.HasPassedCodeCoverageCheck ?? undefined;