-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: migrate to esm #413
Conversation
This issue has been linked to a new work item: W-14371724 |
Wr/esm revert temp
@@ -44,3 +44,9 @@ node_modules | |||
.idea | |||
|
|||
oclif.manifest.json | |||
|
|||
oclif.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiple oclif.lock
s here
"/schemas" | ||
"/schemas", | ||
"/oclif.lock", | ||
"/oclif.lock" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiple oclif.lock
s
src/commands/config/set.ts
Outdated
@@ -29,7 +32,7 @@ export class Set extends SfCommand<SetOrUnsetConfigCommandResult> { | |||
}), | |||
}; | |||
|
|||
public static configurationVariablesSection = CONFIG_HELP_SECTION; | |||
public static configurationVariablesSection: HelpSection = CONFIG_HELP_SECTION; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? I removed it locally and typescript didn't mind
@@ -1,8 +0,0 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fairly confident that we need to keep this file for two reasons:
- it's used as the
exports
in the package.json. - This file existing allows
@oclif/core
to more performantly find plugin roots at run time
QA: Setup: Pulled changes, 🟢
🟢 |
What does this PR do?
migrates to esm
What issues does this PR fix or reference?