Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate to esm #413

Merged
merged 24 commits into from
Nov 2, 2023
Merged

feat!: migrate to esm #413

merged 24 commits into from
Nov 2, 2023

Conversation

WillieRuemmele
Copy link
Contributor

What does this PR do?

migrates to esm

What issues does this PR fix or reference?

@git2gus
Copy link

git2gus bot commented Oct 26, 2023

This issue has been linked to a new work item: W-14371724

@@ -44,3 +44,9 @@ node_modules
.idea

oclif.manifest.json

oclif.lock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple oclif.locks here

"/schemas"
"/schemas",
"/oclif.lock",
"/oclif.lock"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple oclif.locks

@@ -29,7 +32,7 @@ export class Set extends SfCommand<SetOrUnsetConfigCommandResult> {
}),
};

public static configurationVariablesSection = CONFIG_HELP_SECTION;
public static configurationVariablesSection: HelpSection = CONFIG_HELP_SECTION;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? I removed it locally and typescript didn't mind

@@ -1,8 +0,0 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fairly confident that we need to keep this file for two reasons:

  1. it's used as the exports in the package.json.
  2. This file existing allows @oclif/core to more performantly find plugin roots at run time

@mdonnalley
Copy link
Contributor

mdonnalley commented Nov 1, 2023

QA:

Setup: Pulled changes, yarn compile && sf plugins link --no-install

🟢 sf config set org-api-version=58.0 --global
🟢 sf config list
🟢 sf config get org-api-version
🟢 sf config unset org-api-version --global
🟢 sf config set org-api-version=58.0 target-dev-hub=devhub --global
🟢 sf config get org-api-version target-dev-hub
🔴 sf config set org-metadata-rest-deploy=true --global

~/repos/salesforcecli/plugin-settings (wr/esm) » sf config set org-metadata-rest-deploy=true --global
 ›   Warning: @salesforce/plugin-settings is a linked ESM module and cannot be auto-transpiled. Existing compiled
 ›   source will be used instead.
? Did you mean org-metadata-rest-deploy? Yes
Error (1): Unknown config name: org-metadata-rest-deploy.

🟢 sf alias set foo=bar
🟢 sf alias list
🟢 sf alias unset foo
🔴 failing nuts

@mdonnalley mdonnalley merged commit 2a1e5cf into main Nov 2, 2023
7 checks passed
@mdonnalley mdonnalley deleted the wr/esm branch November 2, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants