Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slac/table #736

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Slac/table #736

merged 8 commits into from
Oct 31, 2024

Conversation

soridalac
Copy link
Contributor

What does this PR do?

update new table

What issues does this PR fix or reference?

@W-16736203@

@@ -73,11 +73,13 @@ export class OrgShapeDeleteCommand extends SfCommand<OrgShapeDeleteResult | unde
this.logSuccess(messages.getMessage('humanSuccess', [orgId]));
this.log('');
this.styledHeader('Failures');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can move this styledHeader into the title: property - check for all tables

WillieRuemmele
WillieRuemmele previously approved these changes Oct 31, 2024
@WillieRuemmele
Copy link
Contributor

WillieRuemmele commented Oct 31, 2024

QA Notes


⚠️ : we need to enable wrapping in table cells,

┌───────────────────┬──────────┬────────────────────┬────────┬────────────┬──────────────┬────────┐
│ Org Id            │ Username │ Shape Id           │ Status │ Created By │ Created Date │ Alias  │
├───────────────────┼──────────┼────────────────────┼────────┼────────────┼──────────────┼────────┤
│ 00D3i000000XXX8E… │ william… │ 3SRKa0000XXXXiZOXX │ Active │ william.r… │ 2024-10-31T… │ DevHub │

username is cutoff

✅ :

 ➜  ../../oss/plugin-signups/bin/run.js  org create snapshot --name testing1 --source-org [email protected] --description "snapshot used for testing1"
┌────────────────────┬────────────────────────────┐
│ Name               │ Value                      │
├────────────────────┼────────────────────────────┤
│ Id                 │ 0OoKa000000XZAMXXX         │
│ Snapshot Name      │ testing1                   │
│ Description        │ snapshot used for testing1 │
│ Status             │ InProgress                 │
│ Source Org         │ 00DDV000000tcqXXXX         │
│ Created Date       │ 10/31/2024, 01:22 PM       │
│ Last Modified Date │ 10/31/2024, 01:22 PM       │
│ Expiration Date    │                            │
└────────────────────┴────────────────────────────┘

⚠️ : weird wrapping as well, better than no wrapping :)

 ➜  sf org list snapshot                                                                                                      
Org Snapshots [2]
==========================================================================================================================
| Id                 Snapshot Name Status     Source Org Id      Created Date         Last Modified Date   Expiration Date 
| ────────────────── ───────────── ────────── ────────────────── ──────────────────── ──────────────────── ─────────────── 
| 0OoKa000000XZAHXXX testing       InProgress 00DDV000000tcqx2XX 10/31/2024, 01:22 PM 10/31/2024, 01:22 PM                 
| 0OoKa000000XZAMKXX testing1      InProgress 00DDV000000tcqxXXX 10/31/2024, 01:22 PM 10/31/2024, 01:23 PM                 
➜  dreamhouse-lwc git:(main) ✗  hub:(GLOBAL - DevHub) scratch:([email protected])
 ➜  ../../oss/plugin-signups/bin/run.js org list snapshot         
Org Snapshots [2]
┌───────────┬───────────────┬────────────┬────────────────────┬──────────────┬────────────────────┬─────────────────┐
│ Id        │ Snapshot Name │ Status     │ Source Org Id      │ Created Date │ Last Modified Date │ Expiration Date │
├───────────┼───────────────┼────────────┼────────────────────┼──────────────┼────────────────────┼─────────────────┤
│ 0OoKa0000 │ testing       │ InProgress │ 00DDV000000tcqxXXX │ 10/31/2024,  │ 10/31/2024, 01:23  │                 │
│ 00XZAHXXX │               │            │                    │ 01:22 PM     │ PM                 │                 │
│ 0OoKa0000 │ testing1      │ InProgress │ 00DDV000000tcqxXXX │ 10/31/2024,  │ 10/31/2024, 01:23  │                 │
│ 00XZAMXXX │               │            │                    │ 01:22 PM     │ PM                 │                 │
└───────────┴───────────────┴────────────┴────────────────────┴──────────────┴────────────────────┴─────────────────┘

@WillieRuemmele WillieRuemmele merged commit 9e8e548 into main Oct 31, 2024
13 checks passed
@WillieRuemmele WillieRuemmele deleted the Slac/table branch October 31, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants