refactor: devScripts update #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
reviewed
Jul 30, 2024
| @@ -100,7 +100,7 @@ export class Retrieve extends SourceCommand { | |||
|
|
|||
| protected retrieveResult: RetrieveResult | undefined; | |||
| private sourceDir: string | undefined; | |||
| private retrieveTargetDir: string | undefined; | |||
| private retrieveTargetDir!: string; | |||
There was a problem hiding this comment.
moving the setting of this to the top of the run method will justify !
mshanemc
reviewed
Jul 30, 2024
| @@ -185,7 +186,7 @@ export class Retrieve extends SourceCommand { | |||
| unzip: this.unzip, | |||
| }); | |||
|
|
|||
| this.log(`Retrieve ID: ${this.mdapiRetrieve.id}`); | |||
| this.log(`Retrieve ID: ${this.mdapiRetrieve.id ?? ''}`); | |||
There was a problem hiding this comment.
preserves existing behavior (no value present)
mshanemc
reviewed
Jul 30, 2024
| @@ -114,7 +114,7 @@ const resultConverter = (input: StatusOutputRow): StatusResult => { | |||
| type, | |||
| // this string became the place to store information. | |||
| // The JSON now breaks out that info but preserves this property for backward compatibility | |||
| state: `${origin} ${actualState}${conflict ? ' (Conflict)' : ''}` as StatusStateString, | |||
| state: `${origin} ${actualState as string}${conflict ? ' (Conflict)' : ''}` as StatusStateString, | |||
There was a problem hiding this comment.
the map is complete, but Map.get() doesn't guarantee presence
mshanemc
reviewed
Jul 30, 2024
| @@ -25,7 +25,7 @@ export class DeployCancelResultFormatter extends ResultFormatter { | |||
| } | |||
|
|
|||
| public display(): void { | |||
| const deployId = getString(this.result, 'response.id'); | |||
| const deployId = this.result.response.id; | |||
There was a problem hiding this comment.
now that we have types we don't need the goofy get on objects
mshanemc
reviewed
Jul 30, 2024
| const deployErrors = componentErrors === 1 ? `${componentErrors} error.` : `${componentErrors} errors.`; | ||
| const tests = `${testsCompleted}/${testsTotal} tests completed.`; | ||
| const testErrs = testErrors === 1 ? `${testErrors} error.` : `${testErrors} errors.`; | ||
| const deploys = `${componentsDeployed ?? 0}/${componentsTotal ?? 0} components deployed.`; |
mshanemc
reviewed
Jul 30, 2024
| @@ -138,7 +138,7 @@ const processConflicts = (conflicts: ChangeResult[], ux: Ux, message: string): v | |||
| const conflictMap = new Map<string, ConflictResponse>(); | |||
| conflicts.forEach((c) => { | |||
| c.filenames?.forEach((f) => { | |||
| conflictMap.set(`${c.name}#${c.type}#${f}`, { | |||
| conflictMap.set(`${c.name ?? ''}#${c.type ?? ''}#${f}`, { | |||
There was a problem hiding this comment.
also preserve existing behaior
WillieRuemmele
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created via github action [skip-validate-pr]