refactor: devScripts update (#677)

* chore: updates from devScripts

* chore: bump deps

* test: nonzero exit code

* docs: alternative registry example

* chore: bump ts-node

---------

Co-authored-by: mshanemc <[email protected]>

COMMANDS.md

@@ -25,6 +25,6 @@ OPTIONS
                                                                                     invocation
 
 EXAMPLES
-  sfdx plugins:trust:verify --npm @scope/npmName --registry http://my.repo.org:4874
+  sfdx plugins:trust:verify --npm @scope/npmName --registry https://npm.pkg.github.com
   sfdx plugins:trust:verify --npm @scope/npmName
 ```

README.md

@@ -114,7 +114,7 @@ DESCRIPTION
   Verifies the digital signature on an npm package matches the signature and key stored at the expected URLs.
 
 EXAMPLES
-  $ @salesforce/plugin-trust plugins trust verify --npm @scope/npmName --registry http://my.repo.org:4874
+  $ @salesforce/plugin-trust plugins trust verify --npm @scope/npmName --registry https://npm.pkg.github.com
 
   $ @salesforce/plugin-trust plugins trust verify --npm @scope/npmName
 ```

messages/verify.md

@@ -8,7 +8,7 @@ Verifies the digital signature on an npm package matches the signature and key s
 
 # examples
 
-- <%= config.bin %> <%= command.id %> --npm @scope/npmName --registry http://my.repo.org:4874
+- <%= config.bin %> <%= command.id %> --npm @scope/npmName --registry https://npm.pkg.github.com
 
 - <%= config.bin %> <%= command.id %> --npm @scope/npmName
 

package.json

@@ -9,19 +9,19 @@
   "bugs": "https://github.com/forcedotcom/cli/issues",
   "dependencies": {
     "@oclif/core": "^3.13.1",
-    "@salesforce/core": "^6.1.3",
-    "@salesforce/sf-plugins-core": "^5.0.4",
+    "@salesforce/core": "^6.4.0",
+    "@salesforce/sf-plugins-core": "^5.0.8",
     "got": "^13.0.0",
     "npm": "10.2.3",
     "npm-run-path": "^4.0.1",
     "proxy-agent": "^6.3.1",
     "shelljs": "^0.8.4"
   },
   "devDependencies": {
-    "@oclif/plugin-command-snapshot": "^5.0.3",
-    "@salesforce/cli-plugins-testkit": "^5.0.6",
-    "@salesforce/dev-scripts": "^8.0.0",
-    "@salesforce/plugin-command-reference": "^3.0.47",
+    "@oclif/plugin-command-snapshot": "^5.0.4",
+    "@salesforce/cli-plugins-testkit": "^5.1.1",
+    "@salesforce/dev-scripts": "^8.1.0",
+    "@salesforce/plugin-command-reference": "^3.0.54",
     "@salesforce/plugin-telemetry": "^2.3.8",
     "@salesforce/ts-sinon": "^1.4.18",
     "@types/shelljs": "^0.8.15",
@@ -30,7 +30,7 @@
     "oclif": "^4.0.4",
     "shx": "0.3.4",
     "sinon-chai": "^3.7.0",
-    "ts-node": "^10.9.1",
+    "ts-node": "^10.9.2",
     "typescript": "^5.2.2"
   },
   "config": {},
@@ -90,6 +90,7 @@
     "compile": "wireit",
     "docs": "sf-docs",
     "format": "wireit",
+    "link-check": "wireit",
     "lint": "wireit",
     "postpack": "shx rm -f oclif.manifest.json oclif.lock",
     "prepack": "sf-prepack",
@@ -159,7 +160,8 @@
         "test:command-reference",
         "test:deprecation-policy",
         "lint",
-        "test:json-schema"
+        "test:json-schema",
+        "link-check"
       ]
     },
     "test:only": {
@@ -178,7 +180,7 @@
       "output": []
     },
     "test:command-reference": {
-      "command": "ts-node \"./bin/dev.js\" commandreference:generate --erroronwarnings",
+      "command": "node --loader ts-node/esm --no-warnings=ExperimentalWarning \"./bin/dev.js\" commandreference:generate --erroronwarnings",
       "files": [
         "src/**/*.ts",
         "messages/**",
@@ -189,7 +191,7 @@
       ]
     },
     "test:deprecation-policy": {
-      "command": "ts-node \"./bin/dev.js\" snapshot:compare",
+      "command": "node --loader ts-node/esm --no-warnings=ExperimentalWarning \"./bin/dev.js\" snapshot:compare",
       "files": [
         "src/**/*.ts"
       ],
@@ -199,12 +201,21 @@
       ]
     },
     "test:json-schema": {
-      "command": "ts-node \"./bin/dev.js\" schema:compare",
+      "command": "node --loader ts-node/esm --no-warnings=ExperimentalWarning \"./bin/dev.js\" schema:compare",
       "files": [
         "src/**/*.ts",
         "schemas"
       ],
       "output": []
+    },
+    "link-check": {
+      "command": "node -e \"process.exit(process.env.CI ? 0 : 1)\" || linkinator \"**/*.md\" --skip \"CHANGELOG.md|node_modules|test/|confluence.internal.salesforce.com|%s\" --markdown --retry --directory-listing --verbosity error",
+      "files": [
+        "./*.md",
+        "./!(CHANGELOG).md",
+        "messages/**/*.md"
+      ],
+      "output": []
     }
   },
   "exports": "./lib/index.js",

test/nuts/plugin-install.nut.ts

@@ -69,7 +69,7 @@ describe('plugins:install commands', () => {
       `plugins:install ${UNSIGNED_MODULE_NAME}`,
       { 'continue the installation': Interaction.No },
       {
-        ensureExitCode: 2, // code 2 is the output code for the NO answer
+        ensureExitCode: 'nonZero',
         cli: 'sf',
       }
     );