Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v0.20.0 #753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 10, 2025

πŸ€– New release

  • salsa-macro-rules: 0.19.0 -> 0.20.0 (βœ“ API compatible changes)
  • salsa-macros: 0.19.0 -> 0.20.0
  • salsa: 0.19.0 -> 0.20.0 (⚠ API breaking changes)

⚠ salsa breaking changes

--- failure enum_now_doc_hidden: pub enum is now #[doc(hidden)] ---

Description:
A pub enum is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/enum_now_doc_hidden.ron

Failed in:
  enum CycleRecoveryStrategy in file /tmp/.tmpu4lYeq/salsa/src/cycle.rs:74

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/enum_variant_added.ron

Failed in:
  variant EventKind:DidInternValue in /tmp/.tmpu4lYeq/salsa/src/event.rs:96
  variant EventKind:DidReinternValue in /tmp/.tmpu4lYeq/salsa/src/event.rs:105

--- failure function_missing: pub fn removed or renamed ---

Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/function_missing.ron

Failed in:
  function salsa::plumbing::should_backdate_value, previously in file /tmp/.tmp47zfpY/salsa/src/function.rs:135

--- failure function_now_doc_hidden: pub function is now #[doc(hidden)] ---

Description:
A pub function is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/function_now_doc_hidden.ron

Failed in:
  function with_attached_database in file /tmp/.tmpu4lYeq/salsa/src/attach.rs:97
  function always_update in file /tmp/.tmpu4lYeq/salsa/src/update.rs:111
  function views in file /tmp/.tmpu4lYeq/salsa/src/zalsa.rs:63
  function attach in file /tmp/.tmpu4lYeq/salsa/src/attach.rs:88
  function current_revision in file /tmp/.tmpu4lYeq/salsa/src/database.rs:125
  function transmute_data_ptr in file /tmp/.tmpu4lYeq/salsa/src/zalsa.rs:468
  function stamp in file /tmp/.tmpu4lYeq/salsa/src/runtime.rs:60

--- failure function_requires_different_generic_type_params: function now requires a different number of generic type parameters ---

Description:
A function now requires a different number of generic type parameters than it used to. Uses of this function that supplied the previous number of generic types (e.g. via turbofish syntax) will be broken.
        ref: https://doc.rust-lang.org/reference/items/generics.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/function_requires_different_generic_type_params.ron

Failed in:
  function par_map (4 -> 5 generic types) in /tmp/.tmpu4lYeq/salsa/src/parallel.rs:5

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/struct_missing.ron

Failed in:
  struct salsa::plumbing::Cycle, previously in file /tmp/.tmp47zfpY/salsa/src/cycle.rs:20
  struct salsa::Cycle, previously in file /tmp/.tmp47zfpY/salsa/src/cycle.rs:20

--- failure struct_now_doc_hidden: pub struct is now #[doc(hidden)] ---

Description:
A pub struct is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/struct_now_doc_hidden.ron

Failed in:
  struct Value in file /tmp/.tmpu4lYeq/salsa/src/tracked_struct.rs:267
  struct JarImpl in file /tmp/.tmpu4lYeq/salsa/src/accumulator.rs:30
  struct MemoIngredientIndices in file /tmp/.tmpu4lYeq/salsa/src/memo_ingredient_indices.rs:86
  struct Dispatch in file /tmp/.tmpu4lYeq/salsa/src/update.rs:33
  struct NotSingleton in file /tmp/.tmpu4lYeq/salsa/src/input/singleton.rs:51
  struct IngredientImpl in file /tmp/.tmpu4lYeq/salsa/src/interned.rs:57
  struct IngredientCache in file /tmp/.tmpu4lYeq/salsa/src/zalsa.rs:385
  struct SetterImpl in file /tmp/.tmpu4lYeq/salsa/src/input/setter.rs:14
  struct Revision in file /tmp/.tmpu4lYeq/salsa/src/revision.rs:15
  struct IngredientImpl in file /tmp/.tmpu4lYeq/salsa/src/function.rs:96
  struct IngredientImpl in file /tmp/.tmpu4lYeq/salsa/src/accumulator.rs:56
  struct JarImpl in file /tmp/.tmpu4lYeq/salsa/src/tracked_struct.rs:101
  struct IngredientIndex in file /tmp/.tmpu4lYeq/salsa/src/zalsa.rs:79
  struct Value in file /tmp/.tmpu4lYeq/salsa/src/interned.rs:68
  struct StampedValue in file /tmp/.tmpu4lYeq/salsa/src/runtime.rs:52
  struct MemoIngredientSingletonIndex in file /tmp/.tmpu4lYeq/salsa/src/memo_ingredient_indices.rs:102
  struct Id in file /tmp/.tmpu4lYeq/salsa/src/id.rs:20
  struct IngredientIndices in file /tmp/.tmpu4lYeq/salsa/src/memo_ingredient_indices.rs:11
  struct JarImpl in file /tmp/.tmpu4lYeq/salsa/src/input.rs:40
  struct Runtime in file /tmp/.tmpu4lYeq/salsa/src/runtime.rs:14
  struct Value in file /tmp/.tmpu4lYeq/salsa/src/input.rs:233
  struct IngredientImpl in file /tmp/.tmpu4lYeq/salsa/src/input.rs:72
  struct ZalsaLocal in file /tmp/.tmpu4lYeq/salsa/src/zalsa_local.rs:27
  struct FieldIngredientImpl in file /tmp/.tmpu4lYeq/salsa/src/input/input_field.rs:19
  struct Singleton in file /tmp/.tmpu4lYeq/salsa/src/input/singleton.rs:14
  struct Storage in file /tmp/.tmpu4lYeq/salsa/src/storage.rs:74
  struct Zalsa in file /tmp/.tmpu4lYeq/salsa/src/zalsa.rs:117
  struct IngredientImpl in file /tmp/.tmpu4lYeq/salsa/src/tracked_struct.rs:159
  struct Array in file /tmp/.tmpu4lYeq/salsa/src/array.rs:5
  struct JarImpl in file /tmp/.tmpu4lYeq/salsa/src/interned.rs:49
  struct DatabaseKeyIndex in file /tmp/.tmpu4lYeq/salsa/src/key.rs:13
  struct FieldIngredientImpl in file /tmp/.tmpu4lYeq/salsa/src/tracked_struct/tracked_field.rs:18

--- failure trait_newly_sealed: pub trait became sealed ---

Description:
A publicly-visible trait became sealed, so downstream crates are no longer able to implement it
        ref: https://rust-lang.github.io/api-guidelines/future-proofing.html#sealed-traits-protect-against-downstream-implementations-c-sealed
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/trait_newly_sealed.ron

Failed in:
  trait salsa::Update in file /tmp/.tmpu4lYeq/salsa/src/update.rs:138
  trait salsa::prelude::Accumulator in file /tmp/.tmpu4lYeq/salsa/src/accumulator.rs:21
  trait salsa::Accumulator in file /tmp/.tmpu4lYeq/salsa/src/accumulator.rs:21

--- failure trait_now_doc_hidden: pub trait is now #[doc(hidden)] ---

Description:
A pub trait is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/trait_now_doc_hidden.ron

Failed in:
  trait Database in file /tmp/.tmpu4lYeq/salsa/src/database.rs:9
  trait Lookup in file /tmp/.tmpu4lYeq/salsa/src/interned.rs:465
  trait Ingredient in file /tmp/.tmpu4lYeq/salsa/src/ingredient.rs:45
  trait TrackedStructInDb in file /tmp/.tmpu4lYeq/salsa/src/tracked_struct.rs:145
  trait Update in file /tmp/.tmpu4lYeq/salsa/src/update.rs:138
  trait Jar in file /tmp/.tmpu4lYeq/salsa/src/ingredient.rs:15
  trait Configuration in file /tmp/.tmpu4lYeq/salsa/src/interned.rs:25
  trait SalsaStructInDb in file /tmp/.tmpu4lYeq/salsa/src/salsa_struct.rs:7
  trait Fallback in file /tmp/.tmpu4lYeq/salsa/src/update.rs:63
  trait HashEqLike in file /tmp/.tmpu4lYeq/salsa/src/interned.rs:446
  trait FromIdWithDb in file /tmp/.tmpu4lYeq/salsa/src/id.rs:88
  trait ZalsaDatabase in file /tmp/.tmpu4lYeq/salsa/src/zalsa.rs:35
  trait HasBuilder in file /tmp/.tmpu4lYeq/salsa/src/input.rs:267
  trait Configuration in file /tmp/.tmpu4lYeq/salsa/src/function.rs:33
  trait Configuration in file /tmp/.tmpu4lYeq/salsa/src/tracked_struct.rs:31
  trait Accumulator in file /tmp/.tmpu4lYeq/salsa/src/accumulator.rs:21
  trait HasStorage in file /tmp/.tmpu4lYeq/salsa/src/storage.rs:68
  trait Configuration in file /tmp/.tmpu4lYeq/salsa/src/input.rs:23
  trait FromId in file /tmp/.tmpu4lYeq/salsa/src/id.rs:70
  trait AsId in file /tmp/.tmpu4lYeq/salsa/src/id.rs:65
  trait MemoIngredientMap in file /tmp/.tmpu4lYeq/salsa/src/memo_ingredient_indices.rs:126

--- warning pub_api_sealed_trait_became_unsealed: public API sealed trait became unsealed ---

Description:
A public API sealed trait has become unsealed, allowing downstream crates to implement it. Reverting this would be a major breaking change.
        ref: https://rust-lang.github.io/api-guidelines/future-proofing.html#sealed-traits-protect-against-downstream-implementations-c-sealed
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/pub_api_sealed_trait_became_unsealed.ron

Failed in:
  trait salsa::AsDynDatabase in file /tmp/.tmpu4lYeq/salsa/src/database.rs:110
Changelog

salsa-macro-rules

0.20.0 - 2025-04-05

Added

  • Drop Debug requirements and flip implementation defaults (#756)

Other

  • rewrite cycle handling to support fixed-point iteration (#603)

salsa-macros

0.20.0 - 2025-04-05

Added

  • Drop Debug requirements and flip implementation defaults (#756)

Other

  • Normalize imports style (#779)
  • Document most safety blocks (#776)
  • bug [salsa-macros]: Improve debug name of tracked methods (#755)
  • rewrite cycle handling to support fixed-point iteration (#603)

salsa

0.20.0 - 2025-04-05

Added

  • Drop Debug requirements and flip implementation defaults (#756)

Fixed

  • #[doc(hidden)] plumbing module (#781)
  • Use changed_at revision when updating fields (#778)

Other

  • Use ThinVec for CycleHeads (#787)
  • Keep edge condvar on stack instead of allocating it in an Arc (#773)
  • allow reuse of cached provisional memos within the same cycle iteration (#786)
  • Implement Lookup/HashEqLike for Arc (#784)
  • Normalize imports style (#779)
  • Clean up par_map a bit (#742)
  • Fix typo in comment (#777)
  • Document most safety blocks (#776)
  • Use html directory for mdbook artifact (#774)
  • Move verified_final from Memo into QueryRevisions (#769)
  • Use ThinVec for MemoTable, halving its size (#770)
  • Remove unnecessary query stack acess in block_on (#771)
  • Replace memo queue with append-only vector (#767)
  • update boxcar (#696)
  • Remove extra page indirection in Table (#710)
  • update release steps (#705)
  • Remove some unnecessary panicking paths in cycle execution (#765)
  • (perf) Pool ActiveQuerys in the query stack (#629)
  • Resolve unwind safety fixme (#761)
  • Enable Garbage Collection for Interned Values (#602)
  • bug [salsa-macros]: Improve debug name of tracked methods (#755)
  • Remove dead code (#764)
  • Reduce unnecessary conditional work in deep_verify_memo (#759)
  • Use a Vec for CycleHeads (#760)
  • Use nextest for miri test runs (#758)
  • Pin half version to prevent CI failure (#757)
  • rewrite cycle handling to support fixed-point iteration (#603)


This PR was generated with release-plz.

Copy link

netlify bot commented Mar 10, 2025

βœ… Deploy Preview for salsa-rs canceled.

Name Link
πŸ”¨ Latest commit 48b9e2b
πŸ” Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/67f17e9f761fb100086a3499

@github-actions github-actions bot force-pushed the release-plz-2025-03-10T22-52-52Z branch 18 times, most recently from b5487e0 to 029c9f1 Compare March 22, 2025 09:11
@github-actions github-actions bot force-pushed the release-plz-2025-03-10T22-52-52Z branch 6 times, most recently from ba299bd to f39f653 Compare March 28, 2025 05:22
@github-actions github-actions bot force-pushed the release-plz-2025-03-10T22-52-52Z branch 3 times, most recently from 872bf98 to 2db2c8e Compare April 3, 2025 15:21
@davidbarsky
Copy link
Contributor

davidbarsky commented Apr 3, 2025

Should we just land this and do a release of 0.20? It'd allow rust-analyzer to update to the new cycle handling.

@github-actions github-actions bot force-pushed the release-plz-2025-03-10T22-52-52Z branch from 2db2c8e to 8421dec Compare April 5, 2025 18:52
@github-actions github-actions bot force-pushed the release-plz-2025-03-10T22-52-52Z branch from 8421dec to 48b9e2b Compare April 5, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant