Skip to content

Remove some unnecessary dynamic dispatch calls #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Apr 19, 2025

Just want to quickly check whether the optimize sees through this properly or not

Copy link

netlify bot commented Apr 19, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit e614ee9
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/6806249adb54f20008cd429f

Copy link

codspeed-hq bot commented Apr 19, 2025

CodSpeed Performance Report

Merging #802 will not alter performance

Comparing Veykril:veykril/push-vnokuklytvwt (e614ee9) with master (883baaf)

Summary

✅ 12 untouched benchmarks

@Veykril Veykril force-pushed the veykril/push-vnokuklytvwt branch 4 times, most recently from 11767e1 to 76ac72d Compare April 19, 2025 11:30
@Veykril Veykril changed the title Allow immediately resolving cycles with a fallback instead of fixpoint Remove some unnecessary dynamic dispatch calls Apr 19, 2025
@Veykril Veykril force-pushed the veykril/push-vnokuklytvwt branch 5 times, most recently from db57a4e to 69cb8fe Compare April 21, 2025 10:09
@Veykril Veykril force-pushed the veykril/push-vnokuklytvwt branch from 69cb8fe to e614ee9 Compare April 21, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant