fix: master_job_cache in saltmaster jinja template #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdschmitt
force-pushed
the
fix_master_job_cache
branch
from
ad2dec9
to
7d13324
Compare
|
Looks like something's wrong with the current pre-commit config yml in |
|
The pipeline failed, but I don't think any of the errors have to do with my PR.. |
|
Hor can I make the CI retry? |
|
Rebase & push |
mdschmitt
force-pushed
the
fix_master_job_cache
branch
from
9c963e3
to
6cfb060
Compare
|
Well, I re-ran the CI and it failed again, but same as last time, I don't think the failures have anything to do with my code... |
|
8 months guys. Please? It's soooo simple. |
* only run `yamllint` when relevant files have changed * avoids having to exclude files/dirs not tracked by Git e.g. .kitchen/, .bundle/ etc. * avoids a `yamllint` bug whereby pillar files under `test/` were not checked due to a conflicting `ignore` entry
mdschmitt
force-pushed
the
fix_master_job_cache
branch
from
6cfb060
to
6e688e0
Compare
|
welp, it's been a year since I opened this. I just rebased again and it looks like the CI still fails, but is still not (afaict) related to my PR. |
|
I accept defeat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No. This sets the default value for
master_job_cacheunless it's explicitly set in Pillar.Related issues and/or pull requests
Fixes #552
Describe the changes you're proposing
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context