[WIP] Test build to check PR process #1989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twangboy
approved these changes
Feb 7, 2024
dmurphy18
changed the title
|
i believe, you just missed a single spot to bump 3005.1 to 3005.5, the respective suite name |
blu-base
reviewed
Feb 15, 2024
| @@ -27,10 +27,10 @@ suites: | |||
| salt_call_command: c:\Program Files\Salt Project\Salt\salt-call.bat | |||
| - name: stable-3005 | |||
| provisioner: | |||
| salt_version: 3005.1-1 | |||
| salt_version: 3005.5-1 | |||
| - name: stable-3005-1 | |||
There was a problem hiding this comment.
this likely need's to be changed to stable-3005-5, too
blu-base
reviewed
Feb 15, 2024
| @@ -303,7 +303,7 @@ suites: | |||
| - openbsd-6 | |||
| - name: stable-3005-1 | |||
There was a problem hiding this comment.
the valie need's to be changed to stable-3005-5
|
Ok, nevermind. I was just trying to dive in a little bit, to see what I can help with in this project |
|
Closing this since was a test of current build PR process, which has issues, see #1987 for actual PR doing the work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Check PR build process
What issues does this PR fix or reference?
Checking how PR build process works - test only