Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent file location handling across APIs #57399

Merged
merged 6 commits into from
May 20, 2020
Merged

Conversation

vnitinv
Copy link
Contributor

@vnitinv vnitinv commented May 20, 2020

What does this PR do?

Fix Juniper#146

What issues does this PR fix or reference?

Fixes:

  • all API should have the same behavior for the user-provided file.
  • In case of proxy model, we can have file located either on master or proxy server itself. So we should handle both cases.

Previous Behavior

  • install_os, load, install_config took file from master, file_copy get_table used to take file from proxy.
  • Also if master/proxy running at same machine, install_os would unnecessarily copy huge file to same server to some tmp file.

New Behavior

  • if master/proxy running at same allocation, file is not copied and can use local file location
  • All APIs now can take file from master using salt://

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@vnitinv vnitinv requested a review from a team as a code owner May 20, 2020 17:10
@ghost ghost requested review from DmitryKuzmenko and removed request for a team May 20, 2020 17:10
Nitin Kumar added 2 commits May 20, 2020 22:49
@vnitinv
Copy link
Contributor Author

vnitinv commented May 20, 2020

@dmurphy18 Would you help in reviewing this?

@dmurphy18 dmurphy18 self-requested a review May 20, 2020 18:11
salt/modules/junos.py Show resolved Hide resolved
salt/modules/junos.py Show resolved Hide resolved
@dwoz dwoz merged commit 567897b into saltstack:master May 20, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRelease-Sodium retired label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

have consistency in path evaluation across APIs
4 participants