Convert test_custom grains test to pytest and fix integration tests fileserver issue

tests/conftest.py

@@ -16,6 +16,7 @@
 import _pytest.skipping
 import more_itertools
 import pytest
+import pytestskipmarkers
 
 import salt
 import salt._logging
@@ -426,7 +427,8 @@ def pytest_itemcollected(item):
             pytest.fail(
                 "The test {!r} appears to be written for pytest but it's not under"
                 " {!r}. Please move it there.".format(
-                    item.nodeid, str(PYTESTS_DIR.relative_to(CODE_DIR)), pytrace=False
+                    item.nodeid,
+                    str(PYTESTS_DIR.relative_to(CODE_DIR)),
                 )
             )
 
@@ -801,6 +803,12 @@ def salt_factories_default_root_dir(salt_factories_default_root_dir):
         dictionary, then that's the value used, and not the one returned by
         this fixture.
     """
+    if os.environ.get("CI") and pytestskipmarkers.utils.platform.is_windows():
+        tempdir = pathlib.Path(
+            os.environ.get("RUNNER_TEMP", r"C:\Windows\Temp")
+        ).resolve()
+        return tempdir / "stsuite"
+
     return salt_factories_default_root_dir / "stsuite"
 
 

tests/filename_map.yml

@@ -155,7 +155,7 @@ salt/engines/*:
   - pytests.unit.engines.test_engines
 
 salt/grains/*:
-  - integration.grains.test_custom
+  - pytests.integration.grains.test_custom
 
 salt/matchers/*:
   - integration.states.test_match

tests/pytests/integration/grains/test_custom.py

@@ -0,0 +1,20 @@
+"""
+Test the custom grains
+"""
+
+import pytest
+
+pytestmark = [
+    pytest.mark.windows_whitelisted,
+    pytest.mark.slow_test,
+]
+
+
+def test_grains_passed_to_custom_grain(salt_call_cli):
+    """
+    test if current grains are passed to grains module functions that have a grains argument
+    """
+    ret = salt_call_cli.run("grains.item", "custom_grain_test")
+    assert ret.returncode == 0
+    assert ret.data
+    assert ret.data["custom_grain_test"] == "itworked"