Skip to content

Commit

Permalink
Release editing
Browse files Browse the repository at this point in the history
  • Loading branch information
sam-k0 committed Oct 6, 2024
1 parent 3f9fb79 commit f859fbd
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 10 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/build_win.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ jobs:
- name: Build ModManagerGUI with PyInstaller
run: |
cd ModManagerGUI # Change to the ModManagerGUI directory
dir # List contents to debug if needed
cd ModManagerGUI
pyinstaller --add-data "../publish/Core;Core" --name ModManagerGUI --windowed main.py
- name: Zip ModManagerGUI directory
Expand All @@ -61,14 +60,15 @@ jobs:
owner: context.repo.owner,
repo: context.repo.repo,
});
// Remove the {?name,label} part from upload_url
const cleanedUploadUrl = latestRelease.data.upload_url.split("{")[0];
return cleanedUploadUrl;
// Clean the URL and append the name query parameter
const cleanedUploadUrl = latestRelease.data.upload_url.split('{')[0];
const finalUploadUrl = `${cleanedUploadUrl}?name=ModManagerGUI_win.zip`; // Append filename to the URL
core.setOutput('upload_url', finalUploadUrl);
- name: Upload ModManagerGUI artifact to release
uses: actions/upload-release-asset@v1
with:
upload_url: ${{ steps.get_release.outputs.result }}
upload_url: ${{ steps.get_release.outputs.upload_url }}
asset_path: ModManagerGUI\dist\ModManagerGUI_win.zip
asset_name: ModManagerGUI_win.zip
asset_content_type: application/zip
Expand Down
7 changes: 3 additions & 4 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Following is an unfinished guide on how to install `ModManagerCore` and `ModMana

> [!TIP]
> You can also execute the `build_linux.sh` script after setting up a venv with pyside6 and pyinstaller installed.
> Also, builds can be found as [artifacts](https://github.com/sam-k0/WoTModAssistantCore/actions/workflows/build_linux.yml) in the `Actions` tab.
> Also, builds can be found in the `Release` tab.
1. Download or build the project.
2. Run `ModManagerGUI`.
Expand All @@ -47,10 +47,9 @@ Following is an unfinished guide on how to install `ModManagerCore` and `ModMana

### Windows
> [!IMPORTANT]
> Please download the latest `artifacts` build from the `Actions->Build Windows` workflow run.
> Release Tab does NOT get updated frequently.
> Please download the latest `Windows release` build from the `Release` tab.
1. Download and unzip the latest [artifact](https://github.com/sam-k0/WoTModAssistantCore/actions/workflows/build_win.yml) or release.
1. Download and unzip the latest release.
2. Run `ModManagerGUI.exe`.
3. On first run, it will prompt you to select the game directory, you can find it by checking the `WargamingGameCenter`->`World Of Tanks`->`Modify Installation`->`open game directory`.
4. Select the path to `WorldOfTanks.exe`.
Expand Down

0 comments on commit f859fbd

Please sign in to comment.