Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen swagger #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

hr3lxphr6j
Copy link

gen swagger docs

@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   79.33%   79.33%           
=======================================
  Files          53       53           
  Lines        3843     3843           
=======================================
  Hits         3049     3049           
  Misses        627      627           
  Partials      167      167

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea5b18...1ad3ef1. Read the comment docs.

@hr3lxphr6j hr3lxphr6j requested a review from kirk91 December 9, 2019 08:58
docs/build.sh Outdated Show resolved Hide resolved
}
}
},
"apiSvcConfigDiscoveryResponse": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. How to use the generated file?
  2. Most messages in discovery.proto won't present in the web api.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirk91 kirk91 added the hold label Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants