Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make name of portfolio image configurable (#41) #71

Merged
merged 5 commits into from
Jul 17, 2020
Merged

Make name of portfolio image configurable (#41) #71

merged 5 commits into from
Jul 17, 2020

Conversation

AlexVerrico
Copy link
Contributor

@AlexVerrico AlexVerrico commented Jul 7, 2020 •
edited
Loading

Adds an option to _config.yaml to let the user change the filename of the image.
(Also see issue #41 )

@AlexVerrico
Copy link
Contributor Author

Hi @samarsault
Any update here?
Cheers,
Alex.

@samarsault
Copy link
Owner

Wouldn't it be better to specify the path relative to the codebase (repo)? I think that leaves less room for confusion.
What do you think?

@AlexVerrico
Copy link
Contributor Author

So the link to the image would be
{{ site.baseurl }}{{site.plainwhite.portfolio_image }} ?

@samarsault
Copy link
Owner

{{ site.baseurl }}{{site.plainwhite.portfolio_image }} ?

{{ site.baseurl }} / {{site.plainwhite.portfolio_image }}`

@AlexVerrico
Copy link
Contributor Author

Hi @samarsault
i have made the changes that you suggested, the link to the image is now
{{ site.baseurl }}/{{site.plainwhite.portfolio_image }}
Cheers,
Alex.

samarsault
samarsault reviewed Jul 12, 2020
View reviewed changes
README.md Outdated

```yaml
plainwhite:
portfolio_image: "portfolio.png" # the filename of the image in /assets/ to display
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this comment? It says assets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @samarsault
I have made the suggested changes.
Cheers,
Alex

@AlexVerrico
Copy link
Contributor Author

@samarsault any update here?

@samarsault samarsault merged commit 01dd39e into samarsault:master Jul 17, 2020
@samarsault
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarsault samarsault samarsault left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexVerrico @samarsault