Upgrade to nodejs v12 #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge the chromium binary. now uses latest puppeteer version as a result of chrome-aws-lambda having matching binaries for each puppeteer version (see: https://github.com/alixaxel/chrome-aws-lambda#versioning)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the sample project to support NodeJS v12 environment of AWS Lambda.
It now uses https://github.com/alixaxel/chrome-aws-lambda to manage the Chromium binary. chrome-aws-lambda goes to great effort to generate a binary for every version of Puppeteer. As a result, the version of puppeteer is no longer pinned to v1.3.0, but can now run the latest and greatest.
I have removed the locally managed binaries, as well as the option to download Chromium from S3. I personally don't use the S3 functionality, and if other people need it, I would steer them to the new Lambda Layers functionality. This project https://github.com/shelfio/chrome-aws-lambda-layer packages up the chrome-aws-lambda binary as an easy-to-use layer, if people are finding the size of the bundled Chromium binary in this starter-kit taking them over the 50mb Lambda package limit.