-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples to json #10
Examples to json #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! 🤩 Just got some minor comments I'd like you to address. Thanks 🙏
Ah just also noticed that there's a falling test. It's not too do with your changes though so shouldn't have snuck through, but do you mind changing "Additions" to "Components" in the test_gh_model.py file, I think it was called? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few minor minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks, good, thanks!
examples to json
models.py updated to input type (NumberSlider)
added examples loading.py
changed imports in pipeline_prompts.py
added examples.json
also for Number Slider, added that bit in the system prompt which tells it to include a number slider for inputs