Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples to json #10

Merged
merged 11 commits into from
Jun 24, 2024
Merged

Examples to json #10

merged 11 commits into from
Jun 24, 2024

Conversation

NicolasFranklin-MM
Copy link
Collaborator

examples to json

models.py updated to input type (NumberSlider)
added examples loading.py
changed imports in pipeline_prompts.py
added examples.json

also for Number Slider, added that bit in the system prompt which tells it to include a number slider for inputs

Copy link
Owner

@samgregson samgregson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 🤩 Just got some minor comments I'd like you to address. Thanks 🙏

data/examples_loading.py Outdated Show resolved Hide resolved
models/models.py Outdated Show resolved Hide resolved
models/models.py Outdated Show resolved Hide resolved
prompts/pipeline_prompts.py Outdated Show resolved Hide resolved
data/examples_loading.py Outdated Show resolved Hide resolved
data/examples_loading.py Outdated Show resolved Hide resolved
data/examples_loading.py Outdated Show resolved Hide resolved
@samgregson
Copy link
Owner

samgregson commented Jun 20, 2024

Ah just also noticed that there's a falling test. It's not too do with your changes though so shouldn't have snuck through, but do you mind changing "Additions" to "Components" in the test_gh_model.py file, I think it was called?

@samgregson samgregson changed the title Main 2 - examples to json Examples to json Jun 20, 2024
Copy link
Owner

@samgregson samgregson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor minor comments.

prompts/pipeline_prompts.py Outdated Show resolved Hide resolved
prompts/pipeline_prompts.py Outdated Show resolved Hide resolved
prompts/pipeline_prompts.py Outdated Show resolved Hide resolved
Copy link
Owner

@samgregson samgregson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good, thanks!

@samgregson samgregson merged commit 4280663 into main Jun 24, 2024
1 check passed
@samgregson samgregson deleted the main_2 branch June 24, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants