Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beam-lib] Invalid receiver handeling #174

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

Threated
Copy link
Member

  • Explicitly check for invalid receivers
  • Fix tests

@Threated Threated requested a review from TKussel October 10, 2023 07:56
Copy link
Member

@TKussel TKussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the feeling, that the handle_invalid_receivers() function can be elegantly replaced by the type system. All my initial ideas would lead to ugly generics, but maybe you have a better idea for a later refactor.

@Threated
Copy link
Member Author

I wanted to create an Extension trait for request which would be very elegant but because async fns in traits are not stable yet I just made it a function. I did not want beam_lib to depend on async_trait but I could maybe create my own future.

@Threated
Copy link
Member Author

Wasn't even that difficult. Its very clean now. Although I hope async traits get stabilized soon.

@Threated Threated merged commit 0a05a0e into develop Oct 10, 2023
15 of 16 checks passed
@Threated Threated deleted the beam-lib/check-invalid-receivers branch October 10, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants