Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security check with cargo audit #73

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

lablans
Copy link
Member

@lablans lablans commented Nov 20, 2022

Had to add this as a separate, scheduled job since it would fail the pipeline on any error and does not integrate with Github's security tab, so error management is somewhat clumsy.

@lablans lablans requested a review from TKussel November 20, 2022 09:31
Copy link
Member

@TKussel TKussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ubuntu-latest does not lead to the same issues we experienced in the build pipeline (please check), this PR is a good addition.

- cron: '0 3 * * 1'
jobs:
audit:
runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the latest tag break this job as well?

@TKussel TKussel merged commit 07d24c3 into develop Nov 21, 2022
@TKussel TKussel deleted the feature/securityscan branch November 21, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants