Add 599 error code

[nightpool]

Thanks for the updates! I've been trying the latest builds from gitlab and they've really cut down on the number of random errors. However, I do still see a "599" error occasionally. It may be thrown either by the nintendo GraphQL api or from the underlying HTTP library. Here's the backtrace I see:

Doesn't look like there are any additional details. I've added the 599 error to the temporary_http_errors array, but let me know what you think.

[nightpool]

I also created a gitlab.fancy.org.uk account to try and contribute this patch, but it looks like i need fork access: https://gitlab.fancy.org.uk/nightpool

[samuelthomas2774]

The SplatNet 3 API appears to return 599 status codes when there's issues with NPLN (although it could also be returning this status code for other reasons as well). Looking at presence server logs this is rare (7 total 599 responses in the last month):

SplatNet 3 itself does not retry automatically on any errors and for 400/401/500/599 doesn't even show an option to retry (only close the app), so I think nxapi should still ask for confirmation before retrying on this status code. As it's returned during major outages I guess it's expected that the user will quickly give up and try again later instead of continually retrying every 30s as nxapi does.

[nightpool]

Ultimately, I don't really think the current alert messages are useful to the user at all, and they're very disruptive when Nxapi is running in the background and I'm not even playing Splatoon at all. This one popped up during a Stardew Valley game, for example.

So maybe the issue is less which status codes should be swallowed and which should be retried, and more that the desktop app needs a way to signal errors less disruptively and retry on its own.

[OctoFloofy]

How many errors are you getting per day?

[samuelthomas2774]

(#41)