Merge pull request #44 from eugenethered/master

fix: when collection does not have property, should still sort
samuk190 · Jun 6, 2024 · 708328b · 708328b
2 parents 55d61a7 + 795f8ba
commit 708328b
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/localbase/api/actions/get.js b/localbase/api/actions/get.js
@@ -41,11 +41,13 @@ export default function get(options = { keys: false }) {
         logMessage += `, ordered by "${ orderByProperty }"`
         if (!options.keys) {
           collection.sort((a, b) => {
+            if (!a.hasOwnProperty(orderByProperty) || !b.hasOwnProperty(orderByProperty)) return 0
             return a[orderByProperty].toString().localeCompare(b[orderByProperty].toString())
           })
         }
         else {
           collection.sort((a, b) => {
+            if (!a.hasOwnProperty(orderByProperty) || !b.hasOwnProperty(orderByProperty)) return 0
             return a.data[orderByProperty].toString().localeCompare(b.data[orderByProperty].toString())
           })
         }