Poster image #264
Merged
Poster image #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255 and fixes #256.
This PR generates "poster" and "thumbnail" jpgs using the same method that hyrax generates a thumbnail for video files.
This is the quick first pass at doing this work that I think we will want to move over to ActiveEncode eventually. The code for this first pass is less than ideal from a cleanliness standpoint but it works. Other shortcomings is that
hydra-derivativesdoesn't currently give a way to specify the offset or the size to generate the still images so both the poster and thumbnail files are identical apart from their file names. The thumbnail is automatically indexed and appears in search results but the poster is not used at all yet. Both the thumbnail and poster will need to be added into the IIIF manifest (#262) which will require work inhyrax-iiif_avandiiif_manifest.@samvera-labs/avalon