CharacterizeJob non-ASCII filename bug #5673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunn
previously approved these changes
Jun 14, 2022
|
@conorom i think this one just needs a rebase. |
conorom
force-pushed
the
5671-characterizejob-encoding-undefined-conversion-error
branch
from
ddc3a8b to
b42b2df
Compare
dunn
approved these changes
Jun 30, 2022
dunn
deleted the
5671-characterizejob-encoding-undefined-conversion-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5671
It would be better to solve #5670 more generally but I'm PR'ing this simple force_encoding solution in heliotrope anyway to make sure filenames with non-ASCII characters can be ingested as before.
I'll just leave this here until I have more time to look at it and/or some feedback accrues.
It wouldn't hurt anything to merge it even it #5670 is solved later, I guess.
@samvera/hyrax-code-reviewers