Parrot rework run through #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
question mark
i think
i don't know if it works on the whole uh procwise stuff but you know what i'm commiting to haing it be more dynamic than just be cringe on the strippable item
although the linter is mad
…mmer.dm to wizard_weapons.dm 2 (tgstation#79700) ## About The Pull Request All the below copied from tgstation#79588 Does as the tin says and renames all instances of 'mjolnir' to 'mjollnir' . They are TECHNICALLY both correct but because 'mjolnir' was only used for the spelling in game for the hammer itself and the icon when worn on the back I decided on two l's. This also means I had to change the icon name for the back sprite If I'm missing any files with it spelt 'mjolnir' please tell me While I was at it i also decided to change singularityhammer.dm to wizard_weapons.dm because apparently the file is supposed to be where wizard weapon are stored and having it be named after a single weapon is confusing incase people add more weapons later on. ## Why It's Good For The Game More consistent spelling. Code wise it makes it more clear what the intended use for a file is ## Changelog :cl: spellcheck: hopefully changed all instances of the word 'mjolnir' to 'mjollnir' /:cl:
## About The Pull Request Fixes tgstation#79709 I thought it was clever to use `priority_announce` for the hallucinations, as means for maintaining parity, unfortunately the proc is not pure and prints reports to the newscasters. Oopsie. This makes it so only reports sent to all players are printed to newscasters. ## Changelog :cl: Melbert fix: Fixes hallucination and encrypted announcements printing to the Newscaster. /:cl:
…gstation#79716) ## About The Pull Request What it says on the tin. I just noticed this now by chance: when I was doing my damage refactor and removing some deprecated code I accidentally moved the indentation up for `handle_bodyparts()`. This proc only has to be called on live mobs so this is adding unneeded overhead.   This PR just shifts the indentation of `handle_bodyparts()` back to being under the else block, where it belongs. ## Why It's Good For The Game Less redundant proc calls. ## Changelog Nothing player facing.
…#79704) ## About The Pull Request What it reads on the title. The traits should be applied to the owner and not the status effect itself. ## Why It's Good For The Game This will fix tgstation#79641. ## Changelog :cl: san7890, Ghommie fix: The Blessing of Insanity now grants no damage slowdown and free hyperspace movement correctly. /:cl:
## About The Pull Request makes the looms `loom_me` proc loop for stackable items (such as cotton). ## Why It's Good For The Game its a looping do_after, which is satisfying (and you don't need to click as much). ## Changelog :cl: qol: looms will now attempt to loop through stackable items (cotton as an example) /:cl: --------- Co-authored-by: san7890 <[email protected]>
…tation#79712) ## About The Pull Request Fixes tgstation#79676 Ticking either the player or admin "do not consider me for ghost roles" excludes you from the pool of candidates in an orbit ghost poll. You will now get a `tgui_alert()` asking you if you want to accept being put into the orbit poll role's before you accept it, putting it in line with every other ghost role in the game. If the player doesn't accept, the proc is re-ran with someone else on the list. ## Why It's Good For The Game We need both of these behaviors present to keep it standard with what players expect with ghost roles, and it is annoying to be an admin/AFK player who gets hotswapped into one of these roles while they're doing stuff. ## Changelog :cl: qol: You will no longer be added to the list for ghost-orbit role polls if you have opted out of getting antag ghost roles in your preferences. qol: You will get a tgui_alert to accept the ghost role if you were selected via the orbit poll, instead of it just throwing you intot he role. /:cl:
## About The Pull Request Fixes the consequences of tgstation#79629 - Verdict is still out on what the root issue is This has been an issue for the last two years and everything I go bananas trying to get a consistent reproduction case to figure out the root issue. After three session of picking, I think it's just a consequence of certain thing in disposals code sleeping due to `addtimer()` and whatnot so I'm just throwing in the towel and just making it so we stop sending atoms to nullspace for no reason. `target_turf` is typically always a present arg, but regardless we are guaranteed to get a valid turf to send people to instead of the deleted mob room. We still `stack_trace()` whenever this happens, so tracking this issue doesn't change any more than the present status quo- we just don't keep torturing mobs by sending them to the shadow realm. ## Why It's Good For The Game One day we'll figure out why we keep getting `null` passed into `forceMove()` like this but today is not that day. i know turfs technically can't be deleted but it's just there as a safety since we nullcheck anyways (which is the whole point of this fix). Let's just stop screwing with players for the time being also the code looks much better ## Changelog :cl: fix: Safeties in the code have been added to prevent things in disposals going into nullspace whenever they get ejected from a pipe - you will just magically spawn at the turf that you were meant to be flung towards. /:cl:
## About The Pull Request When tram electrocution was turned into a component instead of on the turf, the bad luck omen stopped having a chance of electrocuting the mob. Fixes the toast proc to check for the cursed trait, now also applied by the omen. Splits the toast probability into one value for a normal plate, and one for a broken plate or people with omen. Narrows the window of a potential shock with adjusted probability, no chance of electrocution on green. Adds a missing early return for when the tram isn't moving. ## Changelog :cl: LT3 fix: Bad luck omen again raises your chance of getting shocked by the tram plate fix: Tram plate checks and energizes when the tram is moving code: Omen component now applies the cursed trait /:cl:
## About The Pull Request Disposal outlets eject the contents of the holder with a 2 seconds delay. Delete the outlet before the delay is over and the contents will stay stuck inside the holder. Also merging disposal holders doesn't properly register a signal for mobs transfered to the new holder. ## Why It's Good For The Game Bugfixing. Disposal code is a mess. Perhaps related to tgstation#79629 but I couldn't exactly reproduce it. ## Changelog :cl: fix: Fixed a small issue with disposal outlets leaving contents about to be ejected stuck inside the pipe beneath it if deleted. /:cl:
## About The Pull Request General clean up of heart code. - Use `Stop` and `Restart` in `set_heart_attack` - Use `SEND_SOUND()` rather than `playsound_local` for heartbeats - Use `update_icon_blocker` - Correctly ensures ethereal hearts get their overlay - Adds heartbeat animation to ethereal hearts ## Changelog :cl: Melbert code: General heart code cleanup. fix: Heartbeat sound effects are no longer sourced to the exact tile you fell into crit at fix: Abductors glands are less likely to become invisible or look wrong fix: Ethereal hearts are less likely to become invisible or look wrong, and now properly spawn with their shine overlay image: Adds heartbeat animation to beating Ethereal Hearts /:cl:
|
actually i need to squash this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
final checks