Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix n-down media query mixin generator #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

good-idea
Copy link
Contributor

@good-idea good-idea commented Apr 2, 2021

Hiya,

I accidentally pushed my intended change to main. see here

Then I was an impatient bad boy and published at 1.2.1

Using a mixin like @include media('md-down') { ... } wouldn't work because the SASS variable inside calc(...) needs to be escaped.

I've used yarn link to test this locally and it's now doing the trick.

Assuming all is well, we just need an updated changelog. I was going to add this manually but it looks like it's generated somehow? So I didn't want to fuss.

@good-idea good-idea requested a review from conordavidson April 2, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant