-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: skill level change graphs #19
base: main
Are you sure you want to change the base?
Conversation
Thank you @breannamporter - this largely makes sense technically, but how do these blocks work in a "diff" scenario? |
I guess we had only discussed adding this breakdown for racial background and gender identity, so I think we could circle back later to figuring out how to do these breakdowns for the other categories! |
OK! LMK when you've discussed and have clear direction for me, I'll start on the code then. |
hey @hhff sorry i think im confused here - I though this was blocked because we are waiting for go ahead from the DEI group but it seemed like you were waiting for something else from me based on the SOTU weekly ship. Can you clarify what you need so I can get you unblocked? |
Yes, that's is a different blocker - not the technical one I'm looking for direction on here @breannamporter
I asked above for you to detail how the radial charts & contextual callout blocks should work in diff-mode. You said you'd circle back on it with me? |
Got it - sorry I meant 'we could circle back later' in the sense that this was out of scope for the current ask and we could address it at another time. We would like to keep all the current graphs as they are and just supplement what we have with the two additional graphs representing the change in skill level over the past year broken down by gender identity and racial background respectively. |
Don't you think that would be a bit confusing? Like what dataset would they pull from? I'd not like this update to break the UI / make it non-sensical in certain cases. I'm looking for clear direction! |
@hhff This change would be made on top of the change that you've already added with the month selector and wouldn't require any additional selections to be made by the user. The selected month would be used to create/populate all the current graphs (as is the current setup). In addition to this, we would grab the dei rollup for the selected month in the previous year (e.g. if the currently selected month is November 2023, we would grab the rollup for November 2022) calculate the skill level breakdowns by gender identity and racial background for that month and then use the results to calculate the diff from the currently selected month's breakdowns, which would populate the two new graphs, Year over year change in Skill Level By Gender Identity November 2023 and Year over year change in Skill Level By Racial Background November 2023. This could also be done without the month selector, although the user would then be limited to viewing the delta only for the current year. We could label the graphs differently to make it more clear what they represent (e.g. Change in Skill Level Breakdown By Gender Identity from November 2022 to November 2023 vs. Year over year change in Skill Level By Gender Identity November 2023). If it's simpler to add these new graphs on a separate page that's linked from the current DEI explorer that's completely fine! Please let me know if anything is still unclear so I can provide answers or we can setup a call to hash out the confusion. |
Ohhh thank you @breannamporter I get it now: these delta graphs/tables are additional UI, not replacing the current UI. All good, I'm unblocked! |
awesome thanks @hhff ! |
Rendered Markdown: https://github.com/sanctuarycomputer/stacks/blob/rfc/skill_level_change_graphs/rfcs/2023-11-16_SKILL_LEVEL_CHANGE_GRAPHS.md