Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add navigation with theme switcher #19

Merged
merged 8 commits into from
Oct 30, 2024
Merged

Add navigation with theme switcher #19

merged 8 commits into from
Oct 30, 2024

Conversation

nahbee10
Copy link

@nahbee10 nahbee10 commented Oct 29, 2024 •
edited
Loading

Description

  • ported over the navigation component from blog website
  • added font files and setup fonts in the css/tailwind config
  • applied dark/light theme style to the nav

Type(s) of changes

  • Bug fix
  • New feature
  • Update to an existing feature

Motivation for PR

How Has This Been Tested?

Tested on local preview

Applicable screenshots

https://www.loom.com/share/296f1175c6d14bf4b9af0f9c8d7dcaf4?sid=f5779de3-66d2-4f77-826d-c51151815da1

Follow-up PR

@nahbee10 nahbee10 marked this pull request as draft October 29, 2024 17:25
@nahbee10 nahbee10 marked this pull request as ready for review October 29, 2024 20:45
@nahbee10 nahbee10 changed the title [WIP] Add navigation with theme switcher Add navigation with theme switcher Oct 29, 2024
mokaymokay
mokaymokay reviewed Oct 30, 2024
View reviewed changes
Copy link

@mokaymokay mokaymokay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are there so many changes? is it only from running prettier?

Screenshot 2024-10-30 at 12 54 22 PM

limsohee1002
limsohee1002 approved these changes Oct 30, 2024
View reviewed changes
Copy link

@limsohee1002 limsohee1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding gitgnore

@nahbee10 nahbee10 merged commit 313480d into master Oct 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mokaymokay mokaymokay mokaymokay left review comments

@limsohee1002 limsohee1002 limsohee1002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Global Elements - Nav
3 participants
@nahbee10 @mokaymokay @limsohee1002