feat: add article page #25
Conversation
limsohee1002
force-pushed
the
feat/article-modules
branch
from
68821ed to
6669b22
Compare
| articlePageData: ArticlePageData; | ||
| }; | ||
|
|
||
| export const ArticleBreadcrumbs: FC<Props> = ({ articlePageData }) => { |
There was a problem hiding this comment.
I'm not seeing breadcrumbs in the preview.. is this data available on the page? why isn't it shown?
There was a problem hiding this comment.
oh that is bug I missed that! I will update it!
There was a problem hiding this comment.
- did you also add image module in this PR? Images are rendered in this way, without any vertical paddings and the gray background(with icon+caption) as the design
| <div className="flex flex-col"> | ||
| <h4 className="transition subheading-2 text-light-neutral-1 dark:text-dark-neutral-1 group-hover:text-light-pink-vibrant dark:group-hover:text-dark-pink-vibrant"> | ||
| {title} | ||
| </h4> | ||
| <p className="body-3 text-light-neutral-2 dark:text-dark-neutral-2">{description}</p> | ||
| </div> | ||
| <div className="transition opacity-0 group-hover:opacity-100"> |
There was a problem hiding this comment.
this creates a bit of regression on the short description items:
|
|
|
|
The link on the image doesn't seem to work anymore... |
Description
#12 Articles - Image module
#21 Articles Markdown styling
#11 Articles Header (Edit Side Nav + On this Page + Breadcrumbs) <- sidenav I didn't work on it yet.
#13 Articles - Rating module
#20 Articles - Related articles module
Add category page
Add section page
Type(s) of changes
Motivation for PR
How Has This Been Tested?
Applicable screenshots
https://www.loom.com/share/1fddc30664d942a79e3cbcc074c29dae?sid=1f72dce9-69f3-41b9-90da-a7c050407ef0
Follow-up PR