-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Submit a request form #27
Conversation
3dea721
to
ab054de
Compare
when are you going to handle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't even know what to review with all the linter changes, but your preview looks good.
handling now using the original approach, i just need to figure out how to show the RA field! UI is also implemented in |
{description && ( | ||
<Hint | ||
className="custom-hint" | ||
dangerouslySetInnerHTML={{ __html: description }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
security team might not like dangerouslySetInnerHTML
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good to ask the security team if they have any script they use for this type of stuff to make sure nothing dangerous is rendering.
One of the issue we have with file difference is we don't have a prettier setup to run before we commit. |
Description
/modules/new-request-form
and/styles/main.css
Type(s) of changes
Motivation for PR
How Has This Been Tested?
Tested on local preview: https://uniswaplabs1730152595.zendesk.com/hc/en-us/requests/new or https://uniswaplabs.zendesk.com/hc/en-us/requests/new
Applicable screenshots
https://www.loom.com/share/d5919715e0784cd8906ed992e3cb2620?sid=1c2afc77-b5cf-4458-9e55-1b5df79ae548
Follow-up PR