Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Submit a request form #27

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Add Submit a request form #27

merged 7 commits into from
Nov 6, 2024

Conversation

nahbee10
Copy link

@nahbee10 nahbee10 commented Nov 4, 2024

Description

  • added UI for Submit a request form
  • see changes in /modules/new-request-form and /styles/main.css
  • [TODO] add logic and UI for the related articles in the form - asking the zendesk support team about how to display the field

Type(s) of changes

  • Bug fix
  • New feature
  • Update to an existing feature

Motivation for PR

How Has This Been Tested?

Tested on local preview: https://uniswaplabs1730152595.zendesk.com/hc/en-us/requests/new or https://uniswaplabs.zendesk.com/hc/en-us/requests/new

Applicable screenshots

https://www.loom.com/share/d5919715e0784cd8906ed992e3cb2620?sid=1c2afc77-b5cf-4458-9e55-1b5df79ae548

Follow-up PR

@nahbee10 nahbee10 marked this pull request as draft November 4, 2024 17:09
@nahbee10 nahbee10 changed the title Add Submit a request form [WIP] Add Submit a request form Nov 4, 2024
@nahbee10 nahbee10 changed the title [WIP] Add Submit a request form Add Submit a request form Nov 5, 2024
@nahbee10 nahbee10 marked this pull request as ready for review November 5, 2024 23:22
@mokaymokay
Copy link

when are you going to handle [TODO] add logic and UI for the related articles in the form - asking the zendesk support team about how to display the field? Looks like they want the original approach implemented!

Copy link

@mokaymokay mokaymokay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even know what to review with all the linter changes, but your preview looks good.

@nahbee10
Copy link
Author

nahbee10 commented Nov 6, 2024

when are you going to handle [TODO] add logic and UI for the related articles in the form - asking the zendesk support team about how to display the field? Looks like they want the original approach implemented!

handling now using the original approach, i just need to figure out how to show the RA field! UI is also implemented in module/related-articles. waiting on the Zendesk support team's response about to show the field.

{description && (
<Hint
className="custom-hint"
dangerouslySetInnerHTML={{ __html: description }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security team might not like dangerouslySetInnerHTML

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to ask the security team if they have any script they use for this type of stuff to make sure nothing dangerous is rendering.

@limsohee1002
Copy link

One of the issue we have with file difference is we don't have a prettier setup to run before we commit.
I think Nahee and I have different, prettier setups locally vs. code. So whenever we save, it updates each other's code lol
I have been working more widely across the project, so Nahee's PR has more change 🤔
maybe we should add precommit hook to make sure we run prettier before

@nahbee10 nahbee10 merged commit 812d4f3 into master Nov 6, 2024
3 checks passed
@mokaymokay mokaymokay deleted the feat/request-form branch November 7, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit Request Form
3 participants