Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar and page #30

Merged
merged 10 commits into from
Nov 11, 2024
Merged

Search bar and page #30

merged 10 commits into from
Nov 11, 2024

Conversation

nahbee10
Copy link

@nahbee10 nahbee10 commented Nov 6, 2024

Description

  • added search bar to hero and header
  • added search result page

Type(s) of changes

  • Bug fix
  • New feature
  • Update to an existing feature

Motivation for PR

How Has This Been Tested?

Tested on local preview: https://uniswaplabs1730152595.zendesk.com/hc/en-us or https://uniswaplabs.zendesk.com/hc/en-us

Applicable screenshots

https://www.loom.com/share/f9064d76f3354877a4a5b4793c5624d5?sid=ca38f5a4-71a3-464b-adeb-ee819278c961

Follow-up PR

@nahbee10 nahbee10 marked this pull request as draft November 6, 2024 22:22
@nahbee10 nahbee10 changed the title Search and header Search bar and page Nov 7, 2024
@nahbee10 nahbee10 marked this pull request as ready for review November 7, 2024 03:36
@limsohee1002
Copy link

@limsohee1002
Copy link

Search seem to work well the x on search bar doesn't seem color within system

@nahbee10
Copy link
Author

nahbee10 commented Nov 7, 2024

@limsohee1002 yeah those two elements are from native Zendesk search UI, and it's a bit hard to hack it since it disappears whenever I try to inspect it. I think it's doable to override the style but needs a bit more trick keeping the widget to inspect or dig into the document. I'll finish this here and add a ticket to address it.

@mokaymokay
Copy link

@nahbee10 I can help if you wanna pair

Screenshot 2024-11-08 at 12 12 45 PM

@nahbee10
Copy link
Author

nahbee10 commented Nov 8, 2024

@nahbee10 I can help if you wanna pair

Thanks!! I also tried with mobile and seems like now I have access to it!!

@nahbee10 nahbee10 merged commit 08d6983 into master Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Elements - Search
3 participants