Merge pull request #1 from dreadnip/use-new-sethtml-event

Use new setHtml event
sanderdlm · Feb 27, 2023 · 86cba6a · 86cba6a
2 parents 5a9c6f1 + b83390a
commit 86cba6a
Show file tree

Hide file tree

Showing 4 changed files with 97 additions and 1,587 deletions.
diff --git a/README.md b/README.md
@@ -44,6 +44,10 @@ class TestController
     ): Response {
         $html = $twig->render('pdf.html.twig');
 
+        // You can use the default options
+        $path = $pdfGenerator->generate($html, 'files/test.pdf');
+
+        // Or control everything by passing custom options
         $printOptions = [
             'printBackground' => true,
             'displayHeaderFooter' => true,
@@ -54,10 +58,17 @@ class TestController
         ];
 
         $browserOptions = [
+            'headless' => false,
             'proxyServer' => '127.0.0.1'
         ];
 
-        $path = $pdfGenerator->generate($html, 'files/test.pdf', $options, $browserOptions);
+        $path = $pdfGenerator->generate(
+            html: $html,
+            path: 'files/test.pdf',
+            printOptions: $options,
+            browserOptions: $browserOptions,
+            timeout: 5000
+        );
 
         return new BinaryFileResponse($path);
     }

diff --git a/composer.json b/composer.json
@@ -14,7 +14,7 @@
   "prefer-stable": true,
   "require": {
     "php": "^7.4 || ^8.0",
-    "chrome-php/chrome": "^1.5",
+    "chrome-php/chrome": "^1.8",
     "symfony/dependency-injection": "^3.4 || ^4.4 || ^5.2 || ^6.0",
     "symfony/http-kernel": "^3.4 || ^4.4 || ^5.2 || ^6.0",
     "symfony/config": "^3.4 || ^4.4 || ^5.2 || ^6.0",

diff --git a/src/Service/PdfGenerator.php b/src/Service/PdfGenerator.php
@@ -5,6 +5,7 @@
 namespace Dreadnip\ChromePdfBundle\Service;
 
 use HeadlessChromium\BrowserFactory;
+use HeadlessChromium\Page;
 
 final class PdfGenerator
 {
@@ -24,14 +25,15 @@ public function generate(
         string $html,
         string $path,
         ?array $printOptions = null,
-        ?array $browserOptions = null
+        ?array $browserOptions = null,
+        int $timeout = 30000
     ): string {
         $browser = $this->browserFactory->createBrowser($browserOptions ?? []);
 
         try {
             $page = $browser->createPage();
 
-            $page->setHtml($html);
+            $page->setHtml($html, $timeout, Page::NETWORK_IDLE);
 
             if ($printOptions === null) {
                 $printOptions = [
@@ -44,7 +46,7 @@ public function generate(
                 ];
             }
 
-            $page->pdf($printOptions)->saveToFile($path, 300000);
+            $page->pdf($printOptions)->saveToFile($path, $timeout);
 
             return $path;
         } finally {

diff --git a/tests/test_source.html b/tests/test_source.html